Reformatting "vhost/vhostname" in rabbitmq docs.

[Shubham82]

In this vhostname and vhosts are same same thing
https://keda.sh/docs/2.0/scalers/rabbitmq-queue/#authentication-parameters
For more robust user experience and symmetry would it be better to use either vhost or vhostname?

[tomkerkhove]

Are you sure they are the same thing? I'm not a RabbitMQ expert so just confirming that.

If they are, then we can improve the docs indeed.

[Shubham82]

AFAIK they both are same. i also asked on keda slack, here is the screenshot of it

if it would sound good i will change it. Maybe @jeffhollan can tell more about it.

[tomkerkhove]

@zroubalik Do you know?

[zroubalik]

Sorry I am no means a Rabbit MQ expert 🤷‍♂️

[tomkerkhove]

Adding @ahmelsayed @yaron2 who implemented this, AFAIK, who might be able to confirm this.

[zroubalik]

You might take a look on this new PRs: #1451 kedacore/keda-docs#339

[Shubham82]

I have looked into this PR, In this vhostName added in metadata to override vhost in host string. and as coderanger suggested these are just two formatting example as also mentioned in the screenshot. so i would suggest to go for vhost for better understanding rather than vhostname because vhostname now used in metadata.

[Shubham82]

Hi!
Any update on this!

[tomkerkhove]

I'm pulling in @coderanger who is more knowledgable on RabbitMQ than @zroubalik or myself.
If you think it's best to align the names and that's the common standard in RabbitMQ world then that's fine for me.

[Shubham82]

Thanks @tomkerkhove i think it should be same (vhost). will wait for @coderanger confirmation. After that we will close this.

[coderanger]

Yeah they should definitely be the same, though which it is kind of doesn't matter. We use queueName and vhostName as the parameters but /vhost would be the more expected thing in a URI I think.

[Shubham82]

thanks @coderanger for confirming this, that is also my concern. @tomkerkhove if its sound good then should i raise PR for it?

[tomkerkhove]

Definately, thanks!