Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variable Management, Package Handling Support and Execution in Parallel #4

Open
zackzhangverkada opened this issue Aug 9, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zackzhangverkada
Copy link

zackzhangverkada commented Aug 9, 2024

Feature Request

Summary:
First, thank you KCL developers for creating this rules_kcl repo!

We have encountered several issues while using the rules_kcl repository in our environment, specifically when attempting to execute example commands. These issues need to be addressed to improve the integration between Bazel and KCL, particularly concerning environment variable management, package handling, and support for kcl mod add.

Issues Identified

1. Example Command Inaccuracy

  • The example command provided in the repository does not work as intended.
  • The actual working command requires specifying environment variables:
    bazel run //:hello.yaml.update --action_env=KCL_PKG_PATH=~/.kcl/kpm/.kpm/,KCL_CACHE_PATH=/tmp/kclcache/ --sandbox_debug --verbose_failures
  • In general, we use Bazel without specifying action_env. It would be great if the command don't require specifying them.

Request:

  • Integrate a mechanism within Bazel to manage these environment variables automatically.

2. Lack of Support for kcl mod add

  • This is already in the roadmap, and we will benefit from them significantly.

3. Execute kcl_run in parallel

  • I am not an expert here, but it is not clear if kcl_run could run in parallel on one machine.
  • If KCL_PKG_PATH are the same across multiple running kcl processes, they don't run in parallel because of package_cache file in KCL_PKG_PATH
  • One benefit of Bazel is executing targets in parallel.

Request:

  • Make it clear if the kcl_run could be executed in parallel.

Thank you very much! This will benefit us significantly.

@Peefy Peefy added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2024
@Peefy
Copy link
Contributor

Peefy commented Aug 10, 2024

Thank you! @zackzhangverkada

These can all be used as improvements to improve KCL Bazel Rules. KCL run can work in parallel. Besides, PRs are also welcome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants