Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Update Automation support for KCLRun #82

Open
blakebarnett opened this issue Jul 2, 2024 · 1 comment
Open

Image Update Automation support for KCLRun #82

blakebarnett opened this issue Jul 2, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@blakebarnett
Copy link

We're looking to use this controller, but we need to provide image update automation. Would it be feasible to add support for this to the KCLRun CR itself, or would we need to somehow add support to the image updater side to handle setting the image and tag via native KCL?

Is there a better way to approach this?

@blakebarnett blakebarnett changed the title ImageUpdateAutomation Support for KCLRun Image Update Automation Support for KCLRun Jul 2, 2024
@blakebarnett blakebarnett changed the title Image Update Automation Support for KCLRun Image Update Automation support for KCLRun Jul 2, 2024
@Peefy Peefy added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 3, 2024
@Peefy
Copy link
Contributor

Peefy commented Jul 3, 2024

Hello, @blakebarnett

There are two ways to achieve automatic image updates here:

  1. CI stage: As mentioned in the document, you can update the configuration fields in KCL code through KCL API/CLI during the CI phase, which is not limited to Image: https://www.kcl-lang.io/docs/user_docs/guides/ci-integration/github-actions
  2. CD stage: Integrate with Git through Flux KCL Controller and update configuration fields in KCL code through KCL API, not limited to Image.

If you use CD to accomplish this, we can gradually align the Flux KCL Controller with the Kustomize KCL Controller's features like other issues #68 and #69. Although there is some workload, the Flux community already has mature components that we can use directly. In short, both Issues and PRs are welcome. ❤️

@Peefy Peefy added the enhancement New feature or request label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants
@blakebarnett @Peefy and others