Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable KCLRun.spec.dependsOn support for both kind: KCLRun and kind: Kustomization #129

Open
ron1 opened this issue Sep 4, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ron1
Copy link
Contributor

ron1 commented Sep 4, 2024

Enhancement

Enable KCLRun.spec.dependsOn support for both kind: KCLRun and kind: Kustomization.

The following property descriptions and test data snippets give the impression that dependsOn currently supports kind: Kustomization only.

description: |-
DependsOn may contain a meta.NamespacedObjectReference slice
with references to Kustomization resources that must be ready before this
Kustomization can be reconciled.

assert.Contains(t, kclRun.Spec.DependsOn[0].Name, "my-kustomization")

dependsOn:
- name: my-kustomization
namespace: default
kind: Kustomization

But after reviewing the code itself, I believe KCLRun.spec.dependsOn currently only supports kind: KCLRun.

At a minimum, the code comments and crd description links referenced above should be updated accordingly if I am correct. This issue, however, goes beyond simple doc changes and instead requests to support both kinds.

@ron1 ron1 changed the title KCLRun.spec.dependsOn should also support kind: KCLRun Enhance KCLRun.spec.dependsOn to also support kind: KCLRun Sep 4, 2024
@ron1 ron1 changed the title Enhance KCLRun.spec.dependsOn to also support kind: KCLRun Enable KCLRun.spec.dependsOn to also support kind: KCLRun Sep 4, 2024
@ron1 ron1 changed the title Enable KCLRun.spec.dependsOn to also support kind: KCLRun Enable KCLRun.spec.dependsOn support for both kind: KCLRun and kind: Kustomization Sep 7, 2024
@Peefy Peefy added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants