Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Upgrade to electron 4.0.4 #257

Open
0608jennylee opened this issue Apr 7, 2019 · 1 comment
Open

Upgrade to electron 4.0.4 #257

0608jennylee opened this issue Apr 7, 2019 · 1 comment
Labels

Comments

@0608jennylee
Copy link
Collaborator

0608jennylee commented Apr 7, 2019

blocks issue #191
blocked by issue #102

electron needs to be upgraded for issue #191 oauth to work, the old version of electron(1.2.8) does not work with some of the github oauth functionality needed.

@pqua613
Copy link
Collaborator

pqua613 commented Apr 7, 2019

I feel like we may need to upgrade the node version which is an entirely larger issue. I've had a look around and found that NODE_MODULE_VERSION was changed to 69 in version 4.0.4 whereas the project uses 48 at the moment. This might be a major problem for the upgrade as an update to node version was attempted for the angular upgrade which proved to be difficult already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants