-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes #147 - Resize line changes panel #316
Fixes #147 - Resize line changes panel #316
Conversation
This reverts commit 6530462.
This reverts commit 6530462.
…nd the command console.
This reverts commit 6530462.
…nd the command console.
…om/hhagenson28/VisualGit_SE701_2019_1 into fix/#147-resize-line-changes-panel
This reverts commit 6530462.
…nd the command console.
…om/hhagenson28/VisualGit_SE701_2019_1 into fix/#147-resize-line-changes-panel
…and added hover effect to see full names of both.
This reverts commit 6530462.
…nd the command console.
…and added hover effect to see full names of both.
Note to reviewer(s): This is going to conflict with #315. Resolving these conflicts shouldn't be too bad, just have a look at the files changed and the reasons it should be pretty straight forward to resolve. Let me know if you need help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Close diff panel on opening repository - Refactors the diff panel component to contain the opening and closing methods. * Fix linting issues
@SamuelZheng11 Yes, this issue with the colours being cut off has been noted in issue #204 and therefore, is not related to my changes. |
Ah Ok I approve then |
This reverts commit 6530462.
…nd the command console.
…and added hover effect to see full names of both.
…nd the command console.
This reverts commit 252e5a1.
…om/hhagenson28/VisualGit_SE701_2019_1 into fix/#147-resize-line-changes-panel
@SamuelZheng11 the conflicts have now been fixed so you can merge this in too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Ive run it again my machine and still works.
Ive cross-referenced with PR #315 and almost all changes are accounted for
Ive left a comment regarding changes to styles.css
Related Issue/Keyword:
Closes #147
Description:
After a lot of trial and error, I have been able to adjust the dimensions of the line changes panel so that:
In order to achieve this I had to restructure how the repository name and branch name are shown in the header. These are now limited to the top line of the header with ellipsis (...) for the overflow but you can hover over the text to see their full names. This was done to ensure that the sizing of the header, footer and body content remains consistent and nothing is being hidden behind anything else.
Making these changes will make issue #279 easier to achieve as well.
Testing:
Steps for manual testing:
None of the lines in the panel should be hidden behind the command console.
Thank you to @SheepySean for your help with the CSS and providing very helpful solutions!
(Please ignore all of the commits to do with the package-lock file, I don't know what its problem is)
Checklist:
npm run lint
) - errors but not related to code I changed for this PR