Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[BUG] The branch search/creation text field does not always clear #324

Open
joel-clarke opened this issue Apr 12, 2019 · 1 comment
Open
Labels
bug Something isn't working very small

Comments

@joel-clarke
Copy link
Collaborator

Describe the bug
This was caused by a accidental change in PR #316, it removed an input to a function being called when the branch drop down is selected. This caused the the text field to not be cleared in some instances, and when attempting to do so would throw an error to the console.

To reproduce
Steps to reproduce the behavior:

  1. Go to the screen where you can view the graph
  2. Enter a branch name
  3. Click anywhere on the application that is unrelated to the branch creation (the branch creation drop down should close)
  4. Re-open the branch drop down
  5. The text field will not be cleared

Expected behavior / Acceptance criteria
In step 5 of the testing the text field should be cleared.

Screenshots
image

Desktop (please complete the following information):

  • Windows 10

Related issues
PR #316
Related to issue #287

@joel-clarke joel-clarke added bug Something isn't working very small labels Apr 12, 2019
@joel-clarke joel-clarke self-assigned this Apr 12, 2019
@SamuelZheng11
Copy link
Collaborator

SamuelZheng11 commented Apr 12, 2019

Uh Edit, I am no longer able to replicate, Windows 10

@joel-clarke joel-clarke removed their assignment Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working very small
Projects
None yet
Development

No branches or pull requests

2 participants