Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

[BUG] Changed file component resetting #187

Open
Z-Qi opened this issue Mar 31, 2019 · 1 comment
Open

[BUG] Changed file component resetting #187

Z-Qi opened this issue Mar 31, 2019 · 1 comment
Labels
bug Something isn't working Medium

Comments

@Z-Qi
Copy link
Collaborator

Z-Qi commented Mar 31, 2019

Describe the bug
In the file panel, if there is a file with uncommitted changes, the file keeps rerendering. This can be seen when the tickbox is selected but after around 1 to 2 seconds it will reset.

This does not occur in surrounding elements, as noted in the gif below, the 'Select All' tickbox and commit message text area do not rerender.

To reproduce
Steps to reproduce the behavior:

  1. Open a repository
  2. If there are no uncommited changes, make one
  3. The file component should now flicker every few seconds and reseting any state within the element

Expected behavior / Acceptance criteria
File component should not be rerendering.

Screenshots
RdHAojsan1

Desktop:

  • OS: Win10
@Z-Qi Z-Qi added bug Something isn't working Medium labels Mar 31, 2019
@Z-Qi Z-Qi changed the title [BUG] [BUG] Changed file component resetting Mar 31, 2019
@rmberriman
Copy link
Collaborator

Confirm that bug exists for new files (For modified files the tick doesn't reset when flicker) as seen below:

Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Medium
Projects
None yet
Development

No branches or pull requests

2 participants