Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output name parameter not validated in narrative when "advanced": true, ? #1612

Open
n1mus opened this issue Apr 2, 2020 · 0 comments
Open
Labels
app-cell Related to App Cells

Comments

@n1mus
Copy link
Contributor

n1mus commented Apr 2, 2020

https://github.com/n1mus/kb_faprotax/blob/96f84b6564cf60bc3b35037623dd3a107f1de2b2/ui/narrative/methods/faprotax/spec.json#L26-L27

I wanted the output name to be advanced, so I kept that as true. I tried toggling "optional", but that never activated the narrative output name validation.

It seems from other apps (and without further testing by iterations of registering), narrative output name validation will work when both "optional" an "advanced" are false.

Also it would be suuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuper great if eventually there was more documentation or a stable spec.json tester in-narrative, for the enhanced mental health of fellow devs (me!!)!

@briehl briehl added the app-cell Related to App Cells label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-cell Related to App Cells
Projects
None yet
Development

No branches or pull requests

2 participants