New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create http client per request call #3

Open

sajjaadalipour opened this issue Dec 25, 2023 · 0 comments

sajjaadalipour commented Dec 25, 2023

Why do you build the HttpClient in the execute method?

I mean this part of the code:

It's better if make the HttpClient instance singleton or get that as a dependency in the KavenegarApi class.

If you want my recommendation, it's better if you give both solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment