Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Methods #4

Open
nildarar opened this issue Feb 21, 2019 · 8 comments
Open

Async Methods #4

nildarar opened this issue Feb 21, 2019 · 8 comments

Comments

@nildarar
Copy link

It's great if you can add async methods to the project.

Thanks for your professional work ...

@HesamKashefi
Copy link

@nildarar
I've created a pull request #6
Supporting Async Methods and Cancellations

@mo-esmp
Copy link
Contributor

mo-esmp commented Apr 30, 2020

Hi, do you have any plan to add async API version? it's really annoying using sync version of API with .NET Core project and it has performance impacts on the application because of thread blocking.

@mhadieskandari
Copy link
Contributor

mhadieskandari commented May 1, 2020

Hi Dear . We have a merge request from Mr @HesamKashefi , after we checked it we get very good changes and we must accept it ,but in due to the Corona virus crisis and because all of our team members have been working remotely these points maybe execute with delay .We are committed to doing this as soon as possible.

@mo-esmp
Copy link
Contributor

mo-esmp commented May 2, 2020

Perhaps after two months, you had enough time to merge @mhadieskandari, hadn't you? By the way, I sent another pull request with minimal changes but I don't think it merged just like HesamKashefi 's pull request.

@mhadieskandari
Copy link
Contributor

@mo-esmp @HesamKashefi

We are sorry for the delay. We appreciate you for your kindness and patience.

We have decided to create another repo for dotnet core to prevent some problems for old customers that need some changes and updates for old technologies.

Could you please do a pull request again on https://github.com/kavenegar/Kavenegar.Core?

@mo-esmp
Copy link
Contributor

mo-esmp commented Nov 21, 2020

Sure, I do ASASP.

@HesamKashefi
Copy link

@mo-esmp @HesamKashefi

We are sorry for the delay. We appreciate you for your kindness and patience.

We have decided to create another repo for dotnet core to prevent some problems for old customers that need some changes and updates for old technologies.

Could you please do a pull request again on https://github.com/kavenegar/Kavenegar.Core?

I did mine,
I have to mention that I removed UrlEncoding from messages because KavenegarAPI is just ignoring them!

@mhadieskandari
Copy link
Contributor

@HesamKashefi Thanks a lot. I will check it and will give you a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants