Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: should @yas/env update NODE_ENV? #223

Open
kasper573 opened this issue Jul 2, 2024 · 0 comments
Open

Investigate: should @yas/env update NODE_ENV? #223

kasper573 opened this issue Jul 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kasper573
Copy link
Owner

Since @yas/env resolves node env like this:

node_env = env.NODE_ENV || env.VERCEL_ENV || "development"

would it not be reasonable to launch the command with that value set to NODE_ENV. this would ensure that mode becomes preview in the following example:

../.. postinstall: @yas/trpc-server:build: 🚀 Loading env flow for preview
../.. postinstall: @yas/trpc-server:build: [[email protected]]: ".env*" files loading failed: no ".env*" files matching pattern ".env[.preview][.local]" in "/vercel/path0/apps/trpc-server" dir undefined
../.. postinstall: @yas/trpc-server:build: ✅  Validated env using: /vercel/path0/apps/trpc-server/src/env.ts
../.. postinstall: @yas/trpc-server:build: {
../.. postinstall: @yas/trpc-server:build:   "env": {
../.. postinstall: @yas/trpc-server:build:     "mode": "development",
@kasper573 kasper573 added the bug Something isn't working label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant