Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading model objects between different versions of TMB #339

Open
kaskr opened this issue Feb 16, 2021 · 0 comments
Open

Loading model objects between different versions of TMB #339

kaskr opened this issue Feb 16, 2021 · 0 comments

Comments

@kaskr
Copy link
Owner

kaskr commented Feb 16, 2021

Description:

It would be nice if saved model objects would remain valid when updating to new versions of TMB - see e.g. glmmTMB/glmmTMB#651 .

Solution idea:

Currently, a TMB model object contains functions (e.g. fn and gr) that explicitly .Call underlying cpp code. This design is highly sensitive to changes in the cpp API. The TMB R code might benefit from re-factoring all the .Call into separate R functions with a fixed R API.

kaskr added a commit that referenced this issue May 13, 2022
- Partly fixing #339: In theory objects generated and saved after this change should be more robust to C++ API changes (e.g. renaming a DLL registered routine shouldn't break the model object.)
- The change also makes it easier to use individual ADFun objects independent of the MakeADFun output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant