From 9be9308ca2911a9fe2925b35c14f7aeccdb7f5ce Mon Sep 17 00:00:00 2001
From: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Date: Fri, 11 Oct 2024 11:51:13 -0700
Subject: [PATCH] fix: tag non-stable settings with new system (#24287)

This PR changes some setting tags as follows:

- Remove the experimental tag from the `python.missingPackage.severity`
setting considering the setting does not seem to be experimental and
that the setting does not seem to be part of any experiment.
- Add the onExP tag onto the `python.locator` setting considering the
setting is both experimental (based on its description) and part of an
experiment.
- Change the experimental tag to preview for
`python.terminal.shellIntegration.enabled`, considering it is a
non-stable setting that does not seem to be part of an experiment.
- Add the onExP tag to `python.REPL.sendToNativeREPL` considering it is
part of an experiment.
---
 package.json     | 13 ++++++-------
 package.nls.json |  4 ++--
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/package.json b/package.json
index 1e43143f3c03..d4c36905d1e3 100644
--- a/package.json
+++ b/package.json
@@ -582,10 +582,7 @@
                         "Warning"
                     ],
                     "scope": "resource",
-                    "type": "string",
-                    "tags": [
-                        "experimental"
-                    ]
+                    "type": "string"
                 },
                 "python.locator": {
                     "default": "js",
@@ -595,7 +592,8 @@
                         "native"
                     ],
                     "tags": [
-                        "experimental"
+                        "experimental",
+                        "onExP"
                     ],
                     "scope": "machine",
                     "type": "string"
@@ -662,7 +660,7 @@
                     "scope": "resource",
                     "type": "boolean",
                     "tags": [
-                        "experimental"
+                        "preview"
                     ]
                 },
                 "python.REPL.enableREPLSmartSend": {
@@ -677,7 +675,8 @@
                     "scope": "resource",
                     "type": "boolean",
                     "tags": [
-                        "experimental"
+                        "experimental",
+                        "onExP"
                     ]
                 },
                 "python.REPL.provideVariables": {
diff --git a/package.nls.json b/package.nls.json
index 8909a3f4c5b9..b60863ef1e49 100644
--- a/package.nls.json
+++ b/package.nls.json
@@ -36,8 +36,8 @@
     "python.diagnostics.sourceMapsEnabled.description": "Enable source map support for meaningful stack traces in error logs.",
     "python.envFile.description": "Absolute path to a file containing environment variable definitions.",
     "python.experiments.enabled.description": "Enables A/B tests experiments in the Python extension. If enabled, you may get included in proposed enhancements and/or features.",
-    "python.experiments.optInto.description": "List of experiment to opt into. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
-    "python.experiments.optOutFrom.description": "List of experiment to opt out of. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
+    "python.experiments.optInto.description": "List of experiments to opt into. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
+    "python.experiments.optOutFrom.description": "List of experiments to opt out of. If empty, user is assigned the default experiment groups. See [here](https://github.com/microsoft/vscode-python/wiki/AB-Experiments) for more details.",
     "python.experiments.All.description": "Combined list of all experiments.",
     "python.experiments.pythonSurveyNotification.description": "Denotes the Python Survey Notification experiment.",
     "python.experiments.pythonPromptNewToolsExt.description": "Denotes the Python Prompt New Tools Extension experiment.",