From 42b63b9a61d4cb0b83bc08906d243fa764a0d518 Mon Sep 17 00:00:00 2001
From: Joar Wandborg <joar@wandborg.se>
Date: Tue, 26 Nov 2024 12:38:37 +0100
Subject: [PATCH] Support ruff `0.8.0` by setting ruff `target-version` to
 `py38` (#24492)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`ruff` 0.8.0 (released 2024-11-22) no longer defaults to supporting
Python 3.8,

> Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Python
version
> is configured using
[`ruff.target-version`](https://docs.astral.sh/ruff/settings/#target-version)
> or
[`project.requires-python`](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires)
>
([https://github.com/microsoft/vscode-python/pull/13896](https://github.com/astral-sh/ruff/pull/13896))
> —
https://github.com/astral-sh/ruff/blob/f3dac27e9aa6ac6a20fc2fb27ff2e4f5d369b076/CHANGELOG.md#080

We want to support Python 3.8 until February 2025, so we need to set
`target-version`.

> The minimum Python version to target, e.g., when considering automatic
code
> upgrades, like rewriting type annotations. Ruff will not propose
changes
> using features that are not available in the given version.
> — https://docs.astral.sh/ruff/settings/#target-version

Can be used as an alternative to
https://github.com/microsoft/vscode-python/pull/24488 until py38 support
is dropped.

This PR also reverts the pinning of `ruff` merged in #24484.
---
 .github/actions/lint/action.yml              | 2 +-
 python_files/pyproject.toml                  | 1 +
 python_files/visualstudio_py_testlauncher.py | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/actions/lint/action.yml b/.github/actions/lint/action.yml
index 60d396e353f3..9992b442c276 100644
--- a/.github/actions/lint/action.yml
+++ b/.github/actions/lint/action.yml
@@ -43,7 +43,7 @@ runs:
 
     - name: Run Ruff
       run: |
-        python -m pip install -U "ruff<0.8.0"
+        python -m pip install -U "ruff"
         python -m ruff check .
         python -m ruff format --check
       working-directory: python_files
diff --git a/python_files/pyproject.toml b/python_files/pyproject.toml
index afb9d372285c..7fb5e18339cb 100644
--- a/python_files/pyproject.toml
+++ b/python_files/pyproject.toml
@@ -23,6 +23,7 @@ ignore = [
 
 [tool.ruff]
 line-length = 100
+target-version = "py38"
 exclude = [
     "**/.data",
     "lib",
diff --git a/python_files/visualstudio_py_testlauncher.py b/python_files/visualstudio_py_testlauncher.py
index 575f9d4fefc2..878491083a71 100644
--- a/python_files/visualstudio_py_testlauncher.py
+++ b/python_files/visualstudio_py_testlauncher.py
@@ -130,7 +130,7 @@ def send_event(self, name, **args):
             body = {"type": "event", "seq": self.seq, "event": name, "body": args}
             self.seq += 1
             content = json.dumps(body).encode("utf8")
-            headers = ("Content-Length: %d\n\n" % (len(content),)).encode("utf8")
+            headers = f"Content-Length: {len(content)}\n\n".encode()
             self.socket.send(headers)
             self.socket.send(content)