Merge KaraokeEvent.UsernameSet and the client-to-server KaraokeEvent.RoomDataHydration #16
Labels
area: game runtime
Improvements to the core game experience.
good first issue
You can do this as a way to learn about the code! ❤
status: accepting prs
This issue is ready for a pull request.
type: cleanup
Improving the structural quality of code or runtime smoothness/performance.
Following #9: there are two initial messages sent from a client to the server when it joins a room:
KaraokeEvent.RoomDataHydration
: A request for the basic room data, made inDynamicSceneHydrating
->useRoomDataConnection
.KaraokeEvent.UsernameSet
: Indicates to the server what the client username is. No response is waited for.For the sake of simplicity & fewer messages, we should really join these two into a single one, named something like
KaraokeNite.RoomJoin
. The client can then send the username in step 1 and still hydrate room data in that same step -- instead of waiting until step 2 to set username.The text was updated successfully, but these errors were encountered: