Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows buttons #13

Closed
wants to merge 14 commits into from
Closed

Conversation

reeseovine
Copy link

@reeseovine reeseovine commented Feb 9, 2016

Adds option for styling title bar like Windows 10. Set an option named 'os' to 'mac' or 'win'.

Also fixes #1.

package.json Outdated
"demo-watch": "wzrd index.js:demo/index.js -- -s titlebar",
"demo-build": "browserify index.js -o demo/index.js -s titlebar"
"start": "wzrd index.js:demo/index.js -- -s titlebar",
"test": "browserify -t brfs index.js -o demo/index.js -s titlebar"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to rename these? I don't think -t brfs is need, the package.json already contains the browserify transform field.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess not. That was left over from my own testing. You can revert that.

@kapetan
Copy link
Owner

kapetan commented Feb 14, 2016

Thanks for the pull-request. I left a couple of comments, you maybe could address.

@reeseovine
Copy link
Author

Hey, I finally got around to fixing those issues you helped me find. Please review my new edits. Thanks!

@ajbeaven
Copy link

Thanks for this pull request @katacarbix. Would be great to see it merged!

@EricRabil
Copy link

Seeing as this is unlikely to be merged any time soon, would you mind publishing your fork to the NPM repository?

@reeseovine
Copy link
Author

Sure! I should tidy it up a bit, but that sounds like a great idea.

@ghost
Copy link

ghost commented Aug 16, 2017

oh let me do that, i am sure i can make it 3 less than 30 lines with modern javascript

@reeseovine
Copy link
Author

Decided to split this off into my own project, which I'm hoping will be an all-in-one solution for titlebars. Check it out here: https://github.com/katacarbix/windowbar

@reeseovine reeseovine closed this Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support windows and other platforms
5 participants