-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows buttons #13
Windows buttons #13
Conversation
todo: style the title bar, fix unmaximize svg
package.json
Outdated
"demo-watch": "wzrd index.js:demo/index.js -- -s titlebar", | ||
"demo-build": "browserify index.js -o demo/index.js -s titlebar" | ||
"start": "wzrd index.js:demo/index.js -- -s titlebar", | ||
"test": "browserify -t brfs index.js -o demo/index.js -s titlebar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to rename these? I don't think -t brfs
is need, the package.json already contains the browserify transform field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I guess not. That was left over from my own testing. You can revert that.
Thanks for the pull-request. I left a couple of comments, you maybe could address. |
Hey, I finally got around to fixing those issues you helped me find. Please review my new edits. Thanks! |
Thanks for this pull request @katacarbix. Would be great to see it merged! |
Seeing as this is unlikely to be merged any time soon, would you mind publishing your fork to the NPM repository? |
Sure! I should tidy it up a bit, but that sounds like a great idea. |
oh let me do that, i am sure i can make it |
Decided to split this off into my own project, which I'm hoping will be an all-in-one solution for titlebars. Check it out here: https://github.com/katacarbix/windowbar |
Adds option for styling title bar like Windows 10. Set an option named 'os' to 'mac' or 'win'.
Also fixes #1.