Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden Job Pod Service Account RBAC Settings #1657

Closed
wants to merge 1 commit into from
Closed

Harden Job Pod Service Account RBAC Settings #1657

wants to merge 1 commit into from

Conversation

Sagar2366
Copy link
Contributor

@Sagar2366 Sagar2366 commented Oct 2, 2022 •
edited
Loading

Change Overview

Adding automountServiceAccountToken: false for pod to not automatically mount service account credentials.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ihcsim
Copy link
Contributor

ihcsim commented Oct 3, 2022

This is not what #1550 is about. A "job pod" is a standalone pod that the Kanister controller creates to perform a specific data protection operation, using the KubeTask function. See #1550 (comment).

@PrasadG193
Copy link
Contributor

Hey @Sagar2366,
As Ivan pointed out, the changes need to be done in the job pod that Kanister creates as a part of BP execution depending on the Kanister functions we use - and not the controller deployment. Please let us know if you need any help with this. We are closing this PR, please feel free to raise a new one.

@PrasadG193 PrasadG193 closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden Job Pod Service Account RBAC Settings
3 participants
@Sagar2366 @ihcsim @PrasadG193