From 472d3672b3c21897269f3f093d8e2df1fe8c1946 Mon Sep 17 00:00:00 2001 From: Daniil Fedotov Date: Mon, 15 Apr 2024 17:29:33 -0400 Subject: [PATCH] Improvements in the release notes scripts and docs --- .gitignore | 2 +- Makefile | 4 ++-- docker/build/Dockerfile | 2 ++ releasenotes/README.md | 4 +++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 83f5ed09b0..ddda7de854 100644 --- a/.gitignore +++ b/.gitignore @@ -8,4 +8,4 @@ /dist **/*.swp /.idea -/releasenotes/config.yaml \ No newline at end of file +/releasenotes/config.yaml diff --git a/Makefile b/Makefile index 024e2c35ef..2e64f66cb1 100644 --- a/Makefile +++ b/Makefile @@ -289,7 +289,7 @@ manifests: ## Generates CustomResourceDefinition objects. @$(MAKE) run CMD="./build/generate_crds.sh ${CONTROLLER_TOOLS_VERSION}" reno-new: - @$(MAKE) run CMD="reno new $(note)" + @PWD=$(PWD) ARCH=$(ARCH) PKG=$(PKG) GITHUB_TOKEN=$(GITHUB_TOKEN) CMD="EDITOR=vim reno new $(note) --edit" /bin/bash ./build/run_container.sh shell reno-report: - @$(MAKE) run CMD="./build/reno_report.sh $(VERSION)" \ No newline at end of file + @$(MAKE) run CMD="./build/reno_report.sh $(VERSION)" diff --git a/docker/build/Dockerfile b/docker/build/Dockerfile index 8ad79ed974..e1cf992f75 100644 --- a/docker/build/Dockerfile +++ b/docker/build/Dockerfile @@ -33,6 +33,8 @@ RUN apt-get update && apt-get install -y pip RUN pip install reno nb2plots +RUN apt-get install -y vim + ENV CGO_ENABLED=0 \ GO111MODULE="on" \ GOROOT="/usr/local/go" \ diff --git a/releasenotes/README.md b/releasenotes/README.md index 27204e94f0..9c66e8825f 100644 --- a/releasenotes/README.md +++ b/releasenotes/README.md @@ -13,13 +13,15 @@ When submitting a PR with some changes worthy of mentioning in the notes (new fe committer should add a new note file using `reno new ` or `make reno-new note=`. New file will be created in `releasenotes/notes` directory with default template. -Change notes should be added to this file to reflect the change and additional information such as deprecations or upgrade requirements. +Summary of the change should be added to this file to reflect the change and additional information such as deprecations or upgrade requirements. It's recommended to remove unused template fields. When reviewing a PR, a reviewer should check if there are change notes added if necessary and either request or add a new note if they have push access to the branch ## Generating changelogs +Changelogs would be generated for each release by maintainers as a part of the release process. + Changelog can be generated using: ```