Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to externally configure options of TaskAgent and FlowAgent #1005

Open
zaychenko-sergei opened this issue Dec 21, 2024 · 0 comments
Open
Labels
rust Pull requests that update Rust code usability Some aspect was unclear or difficult to use

Comments

@zaychenko-sergei
Copy link
Contributor

  1. TaskAgent needs to have configurable waiting interval. Right now it is hardcoded:
    async fn take_task(&self) -> Result<Task, InternalError> {
        loop {
            ...
            tokio::time::sleep(std::time::Duration::from_secs(1)).await;
        }
    }

Defined and inject a configuration object, which is populated from CLI configuration file.

  1. FlowAgent has a configuration object FlowAgentConfig, but it is not connected to CLI configuration file.
    Currently the values are harcoded in app.rs:
    b.add_value(kamu_flow_system_inmem::domain::FlowAgentConfig::new(
        Duration::seconds(1),
        Duration::minutes(1),
    ));
@zaychenko-sergei zaychenko-sergei added usability Some aspect was unclear or difficult to use rust Pull requests that update Rust code labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code usability Some aspect was unclear or difficult to use
Projects
None yet
Development

No branches or pull requests

1 participant