Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings reference .pnpm directory structure #2788

Open
4 tasks
AaronMoat opened this issue Jun 17, 2024 · 0 comments
Open
4 tasks

Typings reference .pnpm directory structure #2788

AaronMoat opened this issue Jun 17, 2024 · 0 comments

Comments

@AaronMoat
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run pnpm generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

Typing files appear to reference the .pnpm directory structure, which breaks type checking when using yarn or npm.

To Reproduce

$ npm init -y
$ npm install --save-dev @graphql-inspector/core
$ grep -r '///' node_modules/@graphql-inspector/core/
node_modules/@graphql-inspector/core//typings/validate/query-depth.d.ts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/alias-count.d.ts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/directive-count.d.ts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/directive-count.d.cts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/complexity.d.cts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/query-depth.d.cts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/complexity.d.ts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />
node_modules/@graphql-inspector/core//typings/validate/alias-count.d.cts:/// <reference types="node_modules/.pnpm/[email protected]/node_modules/dependency-graph/lib" />

Expected behavior

No results for grep

Environment:

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant