Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage stats does not calculate queries, mutations and subscriptions. #2717

Open
4 tasks
osolomin90 opened this issue Apr 26, 2024 · 5 comments
Open
4 tasks
Labels
🐞 bug Something isn't working

Comments

@osolomin90
Copy link

osolomin90 commented Apr 26, 2024

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run pnpm generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

Coverage calculates only root types of queries, mutations and subscriptions when should calculate fields of those root types.
Screenshot 2024-04-26 at 18 19 00

To Reproduce Steps to reproduce the behavior:

Schema:
Screenshot 2024-04-26 at 18 20 52

Root of issue:
Screenshot 2024-04-26 at 18 16 31

Expected result: Each mutation inside Mutation type should be counted.

Environment:

  • OS:
  • @graphql-inspector/...: 4.0.3
  • graphql: 16.6.0
  • NodeJS: 18

Additional context

@TuvalSimha TuvalSimha added the 🐞 bug Something isn't working label May 2, 2024
@TuvalSimha
Copy link
Collaborator

Hey @osolomin90,
thank you for this issue!
Any chance you want to try fix it?

@osolomin90
Copy link
Author

osolomin90 commented May 10, 2024

Hey @osolomin90, thank you for this issue! Any chance you want to try fix it?

@TuvalSimha
I want, but I am not sure if I will have time to sit and solve it...

@osolomin90
Copy link
Author

Hey @osolomin90, thank you for this issue! Any chance you want to try fix it?

@TuvalSimha Hey, I tried to fix it) #2731

@TuvalSimha
Copy link
Collaborator

Hey @osolomin90
thank you very much!
i will take a look soon and update as well!

@DanteUkraine
Copy link
Contributor

@TuvalSimha, I was wondering which release will include stats changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants