From 6ef9c0fd962255c08b09fdbc9ecfa4328a329f81 Mon Sep 17 00:00:00 2001 From: Kamesh Sampath Date: Mon, 8 Apr 2024 11:48:26 +0530 Subject: [PATCH] (workflow): multiple updates - rename image repo - don't use latest tag - add label to dockerfile --- .github/workflows/images.yml | 6 +++--- .github/workflows/release.yml | 4 ++-- .goreleaser.yaml | 2 -- etc/docker/Dockerfile.snowsink | 2 ++ 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/images.yml b/.github/workflows/images.yml index 0fd0c08..31c9710 100644 --- a/.github/workflows/images.yml +++ b/.github/workflows/images.yml @@ -14,7 +14,7 @@ permissions: # issues: write env: - IMAGE_NAME: ghcr.io/${{ github.repository_owner }}/rp-snowflake-sink + IMAGE_REPO: ghcr.io/${{ github.repository_owner }}/rp-snowflake-sink jobs: docker: @@ -40,7 +40,7 @@ jobs: platforms: linux/amd64,linux/arm64 push: true tags: | - ${{ env.IMAGE_NAME }}:latest - ${{ env.IMAGE_NAME }}:${{ github.ref_name }} + ${{ env.IMAGE_REPO }}:latest + ${{ env.IMAGE_REPO }}:${{ github.ref_name }} env: GITHUB_TOKEN: ${{ secrets.MY_GH_ACTION_TOKEN }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b184eb3..d8af74a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,7 +15,7 @@ permissions: # issues: write env: - IMAGE_NAME: ghcr.io/${{ github.repository_owner }}/grpc-todo-app + IMAGE_REPO: ghcr.io/${{ github.repository_owner }}/grpc-todo-app jobs: goreleaser: @@ -37,4 +37,4 @@ jobs: args: release --clean env: GITHUB_TOKEN: ${{ secrets.MY_GH_ACTION_TOKEN }} - KO_DOCKER_REPO: ${{ env.IMAGE_NAME }}/grpc-todo-app + KO_DOCKER_REPO: ${{ env.IMAGE_REPO }} diff --git a/.goreleaser.yaml b/.goreleaser.yaml index 3cccb6c..b37a7ca 100644 --- a/.goreleaser.yaml +++ b/.goreleaser.yaml @@ -76,7 +76,6 @@ kos: labels: org.opencontainers.image.source: https://github.com/kameshsampath/grpc-todo-app tags: - - latest - "{{.Tag}}" - "{{if not .Prerelease}}stable{{end}}" creation_time: "{{.CommitTimestamp}}" @@ -93,7 +92,6 @@ kos: labels: org.opencontainers.image.source: https://github.com/kameshsampath/grpc-todo-app tags: - - latest - "{{.Tag}}" - "{{if not .Prerelease}}stable{{end}}" creation_time: "{{.CommitTimestamp}}" diff --git a/etc/docker/Dockerfile.snowsink b/etc/docker/Dockerfile.snowsink index 47dc1b5..a5b9a64 100644 --- a/etc/docker/Dockerfile.snowsink +++ b/etc/docker/Dockerfile.snowsink @@ -1,5 +1,7 @@ FROM docker.io/confluentinc/cp-kafka-connect-base:7.6.0 AS hub +LABEL org.opencontainers.image.source https://github.com/kameshsampath/grpc-todo-app + # https://www.confluent.io/hub/snowflakeinc/snowflake-kafka-connector # https://www.confluent.io/hub/confluentinc/kafka-connect-protobuf-converter