Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application crash, when trying to load MapBox or map with more than 1 patch #11

Open
Sythelux opened this issue Oct 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Sythelux
Copy link
Collaborator

Sythelux commented Oct 3, 2022

Describe the bug
When I add my Terrain3D and try to load a map and set the patch size x or y to be above 1 the whole editor crashes after a while. The same thing happens, when I try to load a terrain from mapbox

I tried to troubleshoot it with removing and readding code and can't seem to get it to stop. I suppose it has something to do with multiple Patches using the same Material and accessing the same material ID?

It could also be currently buggy, that we hand down the image by ref. I really have no idea. This stuff is pretty much to high for my knowledge level.

To Reproduce
Steps to reproduce the behavior:

  1. see above
  2. after a while (usually after a few hundred milliseconds) the editor crashes

Expected behavior
The Editor continues to run and renders the chunks

Desktop (please complete the following information):

  • OS: PopOS 22.04
  • Engine +version: v4.0.beta.mono.custom_build (e93251e6f96cff29cfc9faed525a496e1d436363)
  • (the same happens with Godot 4 beta 2

Additional context
I have the a stack trace here, but it isn't really helpful.

ERROR: FATAL: Condition "!Object::cast_to<RefCounted>(p_ptr)" is true.
   at: godotsharp_internal_refcounted_disposed (modules/mono/glue/runtime_interop.cpp:155)

================================================================
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v4.0.beta.mono.custom_build (e93251e6f96cff29cfc9faed525a496e1d436363)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/lib/dotnet/dotnet6-6.0.109/shared/Microsoft.NETCore.App/6.0.9/libcoreclr.so(+0x4b536e) [0x7f1467cb536e] (??:0)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7f14a3642520] (??:0)
[3] /opt/Godot/Godot_v4-master_x11_64/godot.linuxbsd.editor.x86_64.llvm.mono(+0xc9880f) [0x5610f282c80f] (??:0)
[4] [0x7f13f0544d5d] (??:0)
-- END OF BACKTRACE --
@Sythelux
Copy link
Collaborator Author

I have progress on this topic. I make it together with this pull request here: #16

Bildschirmfoto vom 2022-11-20 19-16-37

It isn't supposed to load the same one 3 times and they are also not supposed to have different height offsets, but I'll get that working as well.

@Sythelux Sythelux added the bug Something isn't working label Jul 16, 2023
@Sythelux
Copy link
Collaborator Author

Should be fixed with Godot-4.1, but needs verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant