Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id (non-standard?) manifest field for 3.0 will possibly conflict with the id field that is currently being added #56

Open
dmurph opened this issue Sep 20, 2021 · 2 comments

Comments

@dmurph
Copy link

dmurph commented Sep 20, 2021

We have been working on adding the id field to the manifest for a year or so now:

Does the id field in 3.0 behave as proposed in the pull request? If so - awesome! Just wanted to confirm :)

If not - is is possible for us to align here?

@fabricedesre
Copy link

Hi Daniel!

Yes the intent is to use the id field per spec. We moved all the non standard properties under the b2g_features property instead for clarity.

@dmurph
Copy link
Author

dmurph commented Sep 20, 2021

Awesome! Thank you! I think one difference from our original discussion is that we expect the 'computed id' to be a resolved URL, so comparisons between computed ids would be URL comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants