Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gnome 3.12 #36

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Update to gnome 3.12 #36

wants to merge 43 commits into from

Conversation

Psykar
Copy link

@Psykar Psykar commented May 1, 2013

Quite usable!

Icon's don't seem to, as the dbus calls are incorrect.
I haven't tested with 3.4 or 3.6 however.

@magcius
Copy link
Collaborator

magcius commented May 1, 2013

imports.dbus is based on the old libdbus bindings. The new bindings in Gio
are based on GDBus.

(To connect to the 'Changed' signal, use this._proxy.connectSignal. It's
the difference between gobject signals and JS/DBus signals)

On Wed, May 1, 2013 at 3:42 PM, Patrick Ulbrich [email protected]:

imports.dbus seems to have been moved to Gio. I encountered the same
problem while porting the brightness extension to GNOME 3.8.

https://gitorious.org/gnome-shell-brightness-extension/pulbs-gnome-shell-brightness-extension/commit/103ee4e47253f487be7c38cce558b42092d350d3/diffs/e22ebcf1e3d6ad596ff58ac3053eb5a2c856f5e2


Reply to this email directly or view it on GitHubhttps://github.com//pull/36#issuecomment-17301777
.

Jasper

@pulb
Copy link

pulb commented May 1, 2013

imports.dbus is based on the old libdbus bindings. The new bindings in
Gio
are based on GDBus.

(To connect to the 'Changed' signal, use this._proxy.connectSignal.
It's
the difference between gobject signals and JS/DBus signals)

Ah! Good to know, thank you :-)

@Psykar
Copy link
Author

Psykar commented May 1, 2013

Yeah thanks magcius.
This pull request actually has those changes in it. It was more that the icon calls specifically are failing (after changing the dbus interface)

@Psykar Psykar changed the title Update to gnome 3.8 Update to gnome 3.12 Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants