-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed active sidebar menu is highlighted for the correct Kafka instance #324 #540
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get how is this related to #324 which is about tab's title?
Thanks for pointing this out! I looked for the issue related to my task but couldn't find anything. Could you point me to the correct issue if I'm missed something? |
I believe there's no issue related to these changes. I haven't experienced the issue you're describing either, as this is supposed to be a bugfix, let's file a bug report first, as I'm not being able to reproduce this. |
@hotsezus any specific steps to reproduce? |
Nothing special. Just use Here is a services:
kafbat-ui:
image: kafbat/kafka-ui:e7df880cdebe3977d06edee54a538bcaf9416649
restart: on-failure
ports:
- 8080:8080
environment:
DYNAMIC_CONFIG_ENABLED: 'true'
volumes:
- ./config.yml:/etc/kafkaui/dynamic_config.yaml |
What changes did you make?
This pull request addresses a bug in Kafka UI where it was not clear which Kafka instance was being displayed. Previously, the sidebar options (e.g., Topics, Brokers, Consumers) were highlighted for all Kafka instances, causing confusion.
Changes Include:
<instance name> Topics
instead of just "Topics" to clearly indicate which Kafka instance is being viewed.Is there anything you'd like reviewers to focus on?
Please review the changes to ensure:
Fixes #694