You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great if Advantage Reminder could parse a Midi workflow's attackAdvAttribution object and display what it finds on the roll dialog. For example, some Chris's Premades features (such as the Armorer Artificer's thunder gauntlets) add advantage by directly setting workflow.advantage = true, and then calling workflow.attackAdvAttribution.add('descriptive string') (see lines 101 and 102 of this file: https://github.com/chrisk123999/chris-premades/blob/master/scripts/macros/classFeatures/artificer/armorer/armorModel.js). This string is displayed on Midi's chat card after the attack is resolved, and the roll dialog shows that the roll is being made with disadvantage, but Advantage Reminder currently doesn't display why.
I looked at the code very briefly and the biggest issue seems to be that Advantage Reminder would need the workflow object, and I didn't immediately know how to solve that problem. But I thought I'd open the issue here and see if it's a possible enhancement for the module!
The text was updated successfully, but these errors were encountered:
SagaTympana
changed the title
In Midi QOL, add Advantage Reminders for advantage attribution in workflow.attackAdvAttribution
Feature Request: With Midi QOL, add Advantage Reminders for advantage attribution in workflow.attackAdvAttribution
Feb 20, 2024
I remember when I added the adv/dis sources as a message working with Tim with a few things. I knew he was considering showing the sources but I didn't realize he added it in. I suppose I could, but like you said, finding a way to get the workflow object will be the trick. Would also rely on whatever macros were run adding it before that happens.
I'll take a peek at Midi's code to see what I can find.
It would be great if Advantage Reminder could parse a Midi workflow's attackAdvAttribution object and display what it finds on the roll dialog. For example, some Chris's Premades features (such as the Armorer Artificer's thunder gauntlets) add advantage by directly setting
workflow.advantage = true
, and then callingworkflow.attackAdvAttribution.add('descriptive string')
(see lines 101 and 102 of this file: https://github.com/chrisk123999/chris-premades/blob/master/scripts/macros/classFeatures/artificer/armorer/armorModel.js). This string is displayed on Midi's chat card after the attack is resolved, and the roll dialog shows that the roll is being made with disadvantage, but Advantage Reminder currently doesn't display why.I looked at the code very briefly and the biggest issue seems to be that Advantage Reminder would need the workflow object, and I didn't immediately know how to solve that problem. But I thought I'd open the issue here and see if it's a possible enhancement for the module!
The text was updated successfully, but these errors were encountered: