Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: With Midi QOL, add Advantage Reminders for advantage attribution in workflow.attackAdvAttribution #57

Open
SagaTympana opened this issue Feb 20, 2024 · 1 comment

Comments

@SagaTympana
Copy link

It would be great if Advantage Reminder could parse a Midi workflow's attackAdvAttribution object and display what it finds on the roll dialog. For example, some Chris's Premades features (such as the Armorer Artificer's thunder gauntlets) add advantage by directly setting workflow.advantage = true, and then calling workflow.attackAdvAttribution.add('descriptive string') (see lines 101 and 102 of this file: https://github.com/chrisk123999/chris-premades/blob/master/scripts/macros/classFeatures/artificer/armorer/armorModel.js). This string is displayed on Midi's chat card after the attack is resolved, and the roll dialog shows that the roll is being made with disadvantage, but Advantage Reminder currently doesn't display why.

I looked at the code very briefly and the biggest issue seems to be that Advantage Reminder would need the workflow object, and I didn't immediately know how to solve that problem. But I thought I'd open the issue here and see if it's a possible enhancement for the module!

@SagaTympana SagaTympana changed the title In Midi QOL, add Advantage Reminders for advantage attribution in workflow.attackAdvAttribution Feature Request: With Midi QOL, add Advantage Reminders for advantage attribution in workflow.attackAdvAttribution Feb 20, 2024
@kaelad02
Copy link
Owner

I remember when I added the adv/dis sources as a message working with Tim with a few things. I knew he was considering showing the sources but I didn't realize he added it in. I suppose I could, but like you said, finding a way to get the workflow object will be the trick. Would also rely on whatever macros were run adding it before that happens.

I'll take a peek at Midi's code to see what I can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants