KIP-0030: SpireKey dApp <> Wallet Connection #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NOTE: the specification is still in draft, we are still testing and trying to make sure everyone can make use of this specification.
Randynamic
previously approved these changes
Oct 3, 2024
Randynamic
approved these changes
Oct 7, 2024
emilypi
reviewed
Oct 23, 2024
| balance: string; | ||
| devices: Device[]; | ||
| guard?: Guard; | ||
| keyset?: Keyset; |
There was a problem hiding this comment.
Is this guard significantly different from the keyset? It would be good to explain the difference.
There was a problem hiding this comment.
Right I haven't written about it, the difference being that the Keyset is the keyset currently registered on the defined keyset, and the guard being the create-ref-guard of that keyset definition.
There was a problem hiding this comment.
I'll update the supporting text around it. 👍
LindaOrtega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped KIP down to dapp <> wallet connection