Fixes mbest#8 - computed doesn't update if dependent on throttled com…

…puted.
k0lpak · Mar 8, 2013 · 7c3fccf · 7c3fccf
1 parent b2dc914
commit 7c3fccf
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/knockout-deferred-updates.js b/knockout-deferred-updates.js
@@ -300,8 +300,12 @@ var newComputed = function (evaluatorFunctionOrOptions, evaluatorFunctionTarget,
         }
     }
 
-    function markAsChanged() {
-        _needsEvaluation = true;
+    function markAsChanged(value) {
+        if (!_possiblyNeedsEvaluation && !_needsEvaluation) {
+            evaluatePossiblyAsync(value, 'change');
+        } else {
+            _needsEvaluation = true;
+        }
     }
 
     function addDependency(subscribable) {

diff --git a/spec/asyncBehaviors.js b/spec/asyncBehaviors.js
@@ -42,10 +42,17 @@ asyncTest("Should notify subscribers asynchronously after dependencies stop upda
 	var asyncDepObs = ko.dependentObservable(function() {
 		return lastUpdateValue = underlying();
 	}).extend({ throttle: 100 });
-	var notifiedValues = []
+	var notifiedValues = [];
 	asyncDepObs.subscribe(function(value) {
 		notifiedValues.push(value);
 	});
+	var computedNotifiedValues = [];
+    var secondComputed = ko.computed(function() {
+        var value = asyncDepObs();
+        if (value)
+		  computedNotifiedValues.push(value);
+        return value;
+    });
 
 	// Check initial state
 	start();
@@ -55,6 +62,7 @@ asyncTest("Should notify subscribers asynchronously after dependencies stop upda
 	underlying('New value');
 	equal(lastUpdateValue, undefined, 'Should not update synchronously');
 	equal(notifiedValues.length, 0);
+	equal(computedNotifiedValues.length, 0);
 	stop();
 
 	// Wait
@@ -63,6 +71,7 @@ asyncTest("Should notify subscribers asynchronously after dependencies stop upda
 		start();
 		equal(lastUpdateValue, undefined, 'Should not update until throttle timeout');
 		equal(notifiedValues.length, 0);
+    	equal(computedNotifiedValues.length, 0);
 		stop();
 
 		// Wait again
@@ -71,6 +80,8 @@ asyncTest("Should notify subscribers asynchronously after dependencies stop upda
 			equal(lastUpdateValue, 'New value');
 			equal(notifiedValues.length, 1);
 			equal(notifiedValues[0], 'New value');
+        	equal(computedNotifiedValues.length, 1);
+			equal(computedNotifiedValues[0], 'New value');
 		}, 60);
 	}, 50);
 });