Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/javadoc #15

Closed
wants to merge 2 commits into from
Closed

Feature/javadoc #15

wants to merge 2 commits into from

Conversation

ktSuW
Copy link

@ktSuW ktSuW commented Jan 19, 2021

#7 Added JavaDoc to classes:

  1. AbstractPlayableObjectDeserializer class
  2. GsonFactory
  3. AlbumFull

Modified gitignore file to ignore .idea folder

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 1 alert when merging e393868 into c79474c - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@ktSuW
Copy link
Author

ktSuW commented Jan 19, 2021

Hi @jzheng2017 , This PR is mainly for my git skill (I needed to learn more about git) and for AlbumFull class review. If I can get feedback for AlbumFull class, that would be great. I will continue with the rest and will send PR. Thanks.

Copy link
Owner

@jzheng2017 jzheng2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some feedback. Also, I've mentioned it the previous time, the commit titles do not conform to the commit guidelines.

Also look at the alert that lgtm-com bot gives. This should be fixed.

@jzheng2017 jzheng2017 closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants