Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Visual Studio on ARM #14

Open
atishay opened this issue Apr 11, 2024 · 4 comments
Open

Enable Visual Studio on ARM #14

atishay opened this issue Apr 11, 2024 · 4 comments

Comments

@atishay
Copy link
Contributor

atishay commented Apr 11, 2024

Please update the vsix: https://stackoverflow.com/questions/75216866/cannot-install-github-copilot-on-visual-studio-2022

@justcla
Copy link
Owner

justcla commented Apr 11, 2024

Sorry, I don't understand the issue.
The link refers to a thread about GitHub Copilot. You've created this issue in the SublimeVS repository.

If you are having an issue with the SublimeVS extension, please state the issue. If it's related to GitHub Copilot, you might need to look somewhere else.

Justin

@justcla justcla closed this as completed Apr 11, 2024
@atishay
Copy link
Contributor Author

atishay commented Apr 13, 2024

Hi Justin,

Please update the extension manifest to include ARM:

  <Installation>
    <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.0,)">
      <ProductArchitecture>amd64</ProductArchitecture>
    </InstallationTarget>
    <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.0,)">
      <ProductArchitecture>Arm64</ProductArchitecture>
    </InstallationTarget>
  </Installation>

This is the solution that was earlier used for GitHub Copilot and is also needed for SublimeVS. The current installation target only includes amd64

https://github.com/justcla/SublimeVS/blob/master/SublimeVS/source.extension.vsixmanifest#L16

@justcla justcla reopened this Apr 13, 2024
@justcla
Copy link
Owner

justcla commented Apr 13, 2024

Can you please do it for me and submit a PR?
If you build the VSIX and bump the version, I'll upload it to the marketplace.

@justcla
Copy link
Owner

justcla commented Jun 1, 2024

Extension now enabled for ARM64 support on v2.1.0
😊

Resolved with PR #15 plus version upgrade commit.
Needed to bump the VSK SDK Build Tools to 17.5.
Needed to bump the minimum Keyboard Shortcuts Manager to 3.1.4

Hopefully it works nicely. Please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants