test: add automated Cypress test for card number input validation #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
added
the
Ready for Review
|
Review changes with |
aritro2002
force-pushed
the
card-validation-tests
branch
from
ab51e8b
to
63d34dd
Compare
aritro2002
added
the
Testing
PritishBudhiraja
previously approved these changes
Nov 14, 2024
PritishBudhiraja
force-pushed
the
card-validation-tests
branch
from
63d34dd
to
245029e
Compare
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
Sanskar2001
reviewed
Nov 18, 2024
Comment on lines
30
to
42
| it("should complete the card payment successfully", () => { | ||
| const { cardNo, card_exp_month, card_exp_year, cvc } = stripeCards.successCard; | ||
|
|
||
| getIframeBody().find('[data-testid=cardNoInput]').type(cardNo); | ||
| getIframeBody().find('[data-testid=expiryInput]').type(card_exp_month); | ||
| getIframeBody().find('[data-testid=expiryInput]').type(card_exp_year); | ||
| getIframeBody().find('[data-testid=cvvInput]').type(cvc); | ||
|
|
||
| getIframeBody().get("#submit").click(); | ||
|
|
||
| cy.wait(3000); | ||
| cy.contains("Thanks for your order!").should("be.visible"); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| it("should complete the card payment successfully", () => { | |
| const { cardNo, card_exp_month, card_exp_year, cvc } = stripeCards.successCard; | |
| getIframeBody().find('[data-testid=cardNoInput]').type(cardNo); | |
| getIframeBody().find('[data-testid=expiryInput]').type(card_exp_month); | |
| getIframeBody().find('[data-testid=expiryInput]').type(card_exp_year); | |
| getIframeBody().find('[data-testid=cvvInput]').type(cvc); | |
| getIframeBody().get("#submit").click(); | |
| cy.wait(3000); | |
| cy.contains("Thanks for your order!").should("be.visible"); | |
| }); |
There was a problem hiding this comment.
This is already being tested in an existing test case, please remove this
Sanskar2001
reviewed
Nov 18, 2024
|
|
||
| getIframeBody().get("#submit").click(); | ||
|
|
||
| cy.wait(3000); |
There was a problem hiding this comment.
Suggested change
| cy.wait(3000); |
Sanskar2001
reviewed
Nov 18, 2024
|
|
||
| getIframeBody().get("#submit").click(); | ||
|
|
||
| cy.wait(3000); |
There was a problem hiding this comment.
Suggested change
| cy.wait(3000); |
Sanskar2001
reviewed
Nov 18, 2024
|
|
||
| getIframeBody().get("#submit").click(); | ||
|
|
||
| cy.wait(3000); |
There was a problem hiding this comment.
Suggested change
| cy.wait(3000); |
Sanskar2001
reviewed
Nov 18, 2024
|
|
||
| getIframeBody().get("#submit").click(); | ||
|
|
||
| cy.wait(3000); |
There was a problem hiding this comment.
Suggested change
| cy.wait(3000); |
Sanskar2001
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Please add a test suite to verify that when a user enters a value in the card input field and then clears it, no error message is displayed as long as the focus remains on the card input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add automated Cypress test for card number input validation.
How did you test it?
Screen.Recording.2024-11-14.at.3.00.55.PM.mov
Checklist
npm run re:build