Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell content is not recentered after outputs are displayed #93

Open
jpdehollain opened this issue Aug 23, 2024 · 4 comments
Open

Cell content is not recentered after outputs are displayed #93

jpdehollain opened this issue Aug 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jpdehollain
Copy link

Description

Before running a code cell in slideshow mode, the content of all the cells in that slide is centered vertically on the screen. After running the cell, if the cell displays some output (e.g., with print or if plotting a figure), the slide content is not recentered vertically, potentially causing the outputs to be cut-off from the screen.

Recording.2024-08-23.141640.mp4

Reproduce

  1. Create a notebook that includes a code cell that generates some output, such as a plot
  2. View the notebook in slideshow mode and run the cell

Expected behavior

After displaying the output, the content shown on the screen should be re-centered vertically

Context

  • Python package version:
    jupyterlab-rise 0.42.0 pypi_0 pypi

  • Extension version:
    jupyterlab-rise v0.42.0 enabled ok (python, jupyterlab_rise)
    jupyterlab_pygments v0.3.0 enabled ok (python, jupyterlab_pygments)
    @jupyter-notebook/lab-extension v7.2.1 enabled ok
    @jupyter-widgets/jupyterlab-manager v5.0.11 enabled ok (python, jupyterlab_widgets)

    jupyter_lsp enabled

    • Validating jupyter_lsp...
      jupyter_lsp 2.2.5 ok
      jupyter_server_terminals enabled
    • Validating jupyter_server_terminals...
      jupyter_server_terminals 0.5.3 ok
      jupyterlab enabled
    • Validating jupyterlab...
      Extension package jupyterlab took 0.7639s to import
      jupyterlab 4.2.4 ok
      jupyterlab_rise enabled
    • Validating jupyterlab_rise...
      jupyterlab_rise 0.42.0 ok
      notebook enabled
    • Validating notebook...
      notebook 7.2.1 ok
      notebook_shim enabled
    • Validating notebook_shim...
      notebook_shim ok
  • Operating System and its version: Windows 11

  • Browser and its version: Microsoft Edge for Business Version 127.0.2651.105 (Official build) (64-bit)

@jpdehollain jpdehollain added the bug Something isn't working label Aug 23, 2024
@jpdehollain
Copy link
Author

I found an ok workaround. After the figure is displayed, click on it and all the content on the slide gets re-centered

@kir0ul
Copy link

kir0ul commented Oct 4, 2024

I have the same issue.

I found an ok workaround. After the figure is displayed, click on it and all the content on the slide gets re-centered

@jpdehollain What browser are you using? It doesn't work for me on Firefox.

@kir0ul
Copy link

kir0ul commented Oct 4, 2024

Is there any way to "reserve" the space? Or to specify that a specific slide should be aligned on top instead of centered?

@jpdehollain
Copy link
Author

jpdehollain commented Oct 7, 2024

@jpdehollain What browser are you using? It doesn't work for me on Firefox.

@kir0ul I have tried with Edge and Firefox and both work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants