Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom CSS URL Possible Double Slash #60

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

sinanbekar
Copy link
Contributor

@sinanbekar sinanbekar commented Dec 6, 2023

This PR fixes custom CSS HTTP request errors when starting JupyterLab server with the same folder as the .ipynb file.

Fixes #27

Example URL: http://localhost:8888/files//rise.css

403 : Forbidden
The error was:

/rise.css is not in root static directory

Copy link

github-actions bot commented Dec 6, 2023

Binder 👈 Launch a Binder on branch sinanbekar/rise/patch-1

@f0k
Copy link

f0k commented Feb 28, 2024

Ran into the same issue, found the same fix (removing the double slash), thank you for doing the PR! The fix looks reasonable to me (I would have hacked in curdir && (curdir + '/') somewhere, but yours looks more elegant). Anyone up to merging it? From the build checks, it seems there is still a formatting problem, and the PR should have a bug label. Assuming that this held the maintainers back, @sinanbekar, do you think you can correct the formatting?

@sinanbekar
Copy link
Contributor Author

Ran into the same issue, found the same fix (removing the double slash), thank you for doing the PR! The fix looks reasonable to me (I would have hacked in curdir && (curdir + '/') somewhere, but yours looks more elegant). Anyone up to merging it? From the build checks, it seems there is still a formatting problem, and the PR should have a bug label. Assuming that this held the maintainers back, @sinanbekar, do you think you can correct the formatting?

Hey @f0k, the lint error was caused by the main branch (package.json). I synced the PR to main. I think it's fine now.

@fcollonval fcollonval added the bug Something isn't working label Feb 29, 2024
@fcollonval fcollonval merged commit d47b4d1 into jupyterlab-contrib:main Feb 29, 2024
4 of 6 checks passed
@afeld
Copy link
Contributor

afeld commented Oct 20, 2024

Hey hey, possible to get this fix released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css not loaded because of MIME type mismatch
4 participants