Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells editing has strange behaviour when pressing keys #33

Closed
ipcoder opened this issue Jul 19, 2023 · 8 comments · Fixed by #61
Closed

Cells editing has strange behaviour when pressing keys #33

ipcoder opened this issue Jul 19, 2023 · 8 comments · Fixed by #61
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ipcoder
Copy link

ipcoder commented Jul 19, 2023

Description

  1. When editing cell content in the slide some strokes (like s, t, ...) are captured instead of be printed as regular characters.
  2. Characters appear not under the cursor

Reproduction

  • JupyterLab 3.5.3
  • jupyterlab_rise 0.2.0
@ipcoder ipcoder added the bug Something isn't working label Jul 19, 2023
@nthiery
Copy link
Contributor

nthiery commented Sep 1, 2023

I confirm that strokes that have a special meaning for rise are captured instead of being inserted here, with jupyterlab 4.0.5 and jupyterlab-rise 0.40.2.

This prevents any non trivial editing in code / markdown cells; e.g. live coding in slides. Hence a blocker for teaching.

@trevorcampbell
Copy link

trevorcampbell commented Sep 11, 2023

I can reproduce this too! This is a major block for using RISE in classes as we used to pre-JLab 4+.

@joelostblom
Copy link

I am experiencing the same thing. Downgrading to notebook 6.* for the time being.

@krassowski krassowski added the help wanted Extra attention is needed label Sep 20, 2023
@arthursimas1
Copy link

I can relate to this problem.

I started to use RISE before Notebook 7 was a thing. Now I just tried to use it again and discovered that it's deprecated alongside Notebook 6.

I needed to downgrade to Notebook 6 to be able to use RISE again.

This is a huge blocker for using RISE when live coding on slideshow mode.

@schmoelder
Copy link

I tried downgrading to jupyterlab 3.6.6 and jupyterlab-rise 0.3.0 but it still does not work. Did anyone find a workaround?

@SamLau95
Copy link

SamLau95 commented Oct 5, 2023

+1 to this issue, I tried to use JupyterLab + RISE for my first day of class but had to drop out of RISE in the middle of lecture when I couldn't type certain characters in slideshow mode code cells.

@briank-git
Copy link
Contributor

briank-git commented Oct 17, 2023

It seems that the shortcuts listed in packages/lab/schema/plugin.json have selectors that target .lm-Widget.reveal which doesn't account for whether or not a slide is in edit or command mode, meaning the keys are captured even when the cell is being actively edited. I believe the selectors should actually target .lm-Widget.slides.jp-mod-commandMode.

I am working on a PR which should only allow the shortcuts when the slide is in command mode.

@nthiery
Copy link
Contributor

nthiery commented Dec 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
9 participants