From 2f75deb293ec538ea736931d049f648abc6b7e1a Mon Sep 17 00:00:00 2001 From: Andrei Rybak Date: Fri, 13 Oct 2023 12:57:33 +0200 Subject: [PATCH] Drop duplicate `isSnapshot` variable in Gradle build script (#3413) Publishing conventions plugin calculates `isSnapshot`: isSnapshot = project.version.toString().contains("SNAPSHOT") twice: 1. at the top of build script junitbuild.publishing-conventions.gradle.kts 2. in configuration of `Sign` tasks. Drop the second `val isSnapshot` to make `Sign` task configuration re-use the variable from the top of the script. --- .../src/main/kotlin/junitbuild.publishing-conventions.gradle.kts | 1 - 1 file changed, 1 deletion(-) diff --git a/gradle/plugins/common/src/main/kotlin/junitbuild.publishing-conventions.gradle.kts b/gradle/plugins/common/src/main/kotlin/junitbuild.publishing-conventions.gradle.kts index bab950933c2a..44d693b44779 100644 --- a/gradle/plugins/common/src/main/kotlin/junitbuild.publishing-conventions.gradle.kts +++ b/gradle/plugins/common/src/main/kotlin/junitbuild.publishing-conventions.gradle.kts @@ -47,7 +47,6 @@ signing { } tasks.withType().configureEach { - val isSnapshot = project.version.toString().contains("SNAPSHOT") onlyIf { !isSnapshot // Gradle Module Metadata currently does not support signing snapshots }