Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Rename in AppDelegate.mm #288

Open
finnp opened this issue Dec 1, 2023 · 1 comment
Open

Missing Rename in AppDelegate.mm #288

finnp opened this issue Dec 1, 2023 · 1 comment

Comments

@finnp
Copy link

finnp commented Dec 1, 2023

Describe the bug
It did not rename the module name in AppDelegate.mm
To Reproduce

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  self.moduleName = @"aiflashcards";
  // You can add your custom initial props in the dictionary below.
  // They will be passed down to the ViewController used by React Native.
  self.initialProps = @{};

  return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
#if DEBUG
  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
#else
  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
#endif
}

@end

Screenshots
Screenshot 2023-12-01 at 11 52 18

Environment (please complete the following information):

  • operating system: macOS 14.0 Beta (23A5286i)
  • npm version: 8.12.1
  • node version: v18.4.0
  • react-native-rename version: latest
  • react-native version: 0.72.7
@finnp
Copy link
Author

finnp commented Dec 1, 2023

The issue appears to be that you use the display name from iOS (CFBundleDisplayName) as current name. Which I don't think commonly would be used as a module name here?

Generally I am missing that distinction in your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant