Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to wanted earlier #120

Closed
Animosity022 opened this issue Oct 20, 2013 · 13 comments
Closed

Move to wanted earlier #120

Animosity022 opened this issue Oct 20, 2013 · 13 comments

Comments

@Animosity022
Copy link

I've been adjusting a fix since I mostly use torrents and if I wait for the normal maintenance to run to mark an episode as wanted, I miss a lot of seeding time.

I've been using this fix now and was wondering if this is something that can be included:

http://sickbeard.com/forums/viewtopic.php?f=4&t=4775

Thanks.

@gitrickm
Copy link

Now I'm confused. I download several shows that air on Sunday night. This morning (Sunday) after 3 a.m., three of them downloaded bogus RAR files. It seems I either need a way to filter out such bogus files, or to delay the setting of the wanted flag until even later.

Without this change, why did they try to download so early?

@Animosity022
Copy link
Author

I don't think sickbeard would ever be able to tell a bogus file. Depends on what providers you are using. I have not seen that issue.

Sounds like someone maybe searched for that episode manually or something I would guess. Check the logs.

@gitrickm
Copy link

Nobody did anything manually. I'll check the log when I get home.

My completion script can detect and delete the bogus file, but that's not enough. I looked at the transmission API but don't see a way to reset the episode to 'wanted'. Clearly, it's much better not to d/l bad files in the first place.

What torrent providers do you use/recommend?

@Animosity022
Copy link
Author

I use BTN for everything now. Prior to that, I used TVT/IPT/TL/SCC. The private trackers tend to not have that issue with bogus files.

@gitrickm
Copy link

I've never used a private tracker and don't think I will. With my .3Mb upload speed and blackout time from 7am to 7pm on weekdays, I don't think I could meet any upload quotas, and I don't want o buy into any vip membership.

I can't easily look at the logs at the moment to see why they started early, but I do see that the episodes are set back to unaired. I suspect that's because the post-processing failed (rar files not recognized) such that the episodes don't make it to the final location.

So, maybe deleting the rar file download from my completion sctipt might be enough if I can't stop the bogus d/l.

@VeNoMouS
Copy link

For my 2 cents, and this isn't related to the ticket... if you use public trackers, you deserve to get fake uploads.. public trackers allow all sorts of idiots and have no quality control.... I for one will not be providing my services to fix this so called "bug".

And back to the ticket... this ticket is INVALID.

@gitrickm
Copy link

VeNoMouS, I'm the one getting the odd fake upload. I accept that you're not interested in that.

I guess I hijacked the OP's thread here. Are you saying his request is invalid? He just wants an option to start the search earlier than 3am, the morning after a show airs.

I jumped in because I'm getting the odd torrent downloaded at 3am of the day a show airs, as if something similar to his request was already implemented. I looked at the current code and the change he points to is not there.

I haven't yet found how and when an episode gets changed form "unaired" to "wanted".

Anyway, I just wanted to make sure you're not closing this as INVALID on my account!

@Animosity022
Copy link
Author

Can you help me understand why it is invalid with a bit of explanation?

I am making a request related to a code fix that I included that helps to get episodes if you are a torrent user rather than waiting till 0300AM. I can continue to modify the code when releases are made yet that is cumbersome and wanted to make others aware if they use torrents more.

@VeNoMouS
Copy link

Because this is more to do with timezone's... and should be resolved with #62

@VeNoMouS
Copy link

Granted I haven't made that code public... YET.... but what it does is when the 3am rolls for tvrage updates , it slides the air time etc to your localtime zone by working out which production "company", which is in a pivot table with their timezone. ...

@Animosity022
Copy link
Author

From my experience, many shows are posted prior to their airtime so for me, I like the full window so it continually searches until it finds it. I've been using the code posted above for ~8-10 months just to ensure I don't lose seeding time.

If you feel though based on your knowledge, it's a dupe of #62, I will close it out then.

@VeNoMouS
Copy link

Leave it open for now , i've let @junalmeida know im being an asshole :P , he might implement this anyway...

@junalmeida
Copy link
Owner

I agree with @VeNoMouS that this might be related to timezone, and should be fixed after the PR of #62.
I'm closing this as a dupe of #62, @animosity22.

About the bogus torrent file, @gitrickm I'm interested at the effectiveness of your script, but we need to open another ticket to discuss this subject. If your script is really effective to detect a bogus file, I have some ideas to remove it from torrent downloader, set the episode again to wanted and avoid the bogus hash to be redownloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants