Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-mailmap always fails if log.showSignature is enabled in gitconfig #111

Open
Mikaela opened this issue Apr 9, 2023 · 0 comments · May be fixed by #114
Open

check-mailmap always fails if log.showSignature is enabled in gitconfig #111

Mikaela opened this issue Apr 9, 2023 · 0 comments · May be fixed by #114

Comments

@Mikaela
Copy link

Mikaela commented Apr 9, 2023 

Detect if an email address needs to be added to mailmap.......................Failed
- hook id: check-mailmap
- exit code: 1

The following email addresses are associated with more than one name:

        0723
        [expired]
        [ultimate]
        [unknown]
        eest
        eet
        match
        messages.
        minutes.
        past

The associations include:


     19      4 minutes.  Encrypted 0 messages.
    409      Encrypted 0 messages.

after which there will be names and emails.

To reproduce, in repository that contains signed commits,

  1. Enable the check-mailmap pre-commit hook
  - repo: https://github.com/jumanjihouse/pre-commit-hooks
    rev: 3.0.0
    hooks:
      - id: bundler-audit
      - id: check-mailmap
  1. git config log.showSignature true
  2. pre-commit run --all-files
jlec added a commit to jlec/pre-commit-hooks that referenced this issue Oct 15, 2023
@jlec
fix: check-mailmap has problems with log.showSignature true
33728b8 
Fixes jumanjihouse#111

log.showSignature true shows additional signature information. This patch removes the detailed information.
@jlec jlec linked a pull request Oct 15, 2023 that will close this issue
Open
jlec added a commit to jlec/pre-commit-hooks that referenced this issue Oct 15, 2023
@jlec
fix: check-mailmap has problems with log.showSignature true
b30adac 
Fixes jumanjihouse#111

log.showSignature true shows additional signature information. This patch removes the detailed information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check-mailmap has problems with log.showSignature true jlec/pre-commit-hooks
1 participant
@Mikaela