-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF7: Add native support for japanese text rendering #737
base: master
Are you sure you want to change the base?
Conversation
4c86377
to
7599ec1
Compare
7599ec1
to
8df15fd
Compare
8df15fd
to
1ecb51b
Compare
cc397ad
to
a651f32
Compare
b46ce00
to
e057b1a
Compare
Thanks for testing it.
For the iro I was replacing the exe text with hext so I just added a few spaces to fix this.
I think this is because of the broken flevel. Once I fixed that with Makou the location also worked fine for me.
The text here actually is correct but it's going outside the box. |
40b7b1a
to
2e12ea3
Compare
2e12ea3
to
2d256ed
Compare
Thank you so much for this work Cosmos! |
Unlike FF9 the JP data is not included in the Steam release but it's technically possible to make it work with the Steam version if you provide the JP data in an IRO mod. Not sure yet if we it will go in that direction though. |
the android version seems to have broken flevel files too. even the english one. at least the version I got. the windows store version does not have broken flevel files. How exactly did you do the makou reactor fix? i tried editig a text so makour rector would save, and it didn't fix a thing. |
Please do not hijack this PR with offtopic questions. If you need support or help, use Discord support channels. Thank you |
the new ffnx resolves all broken lgp file issues including the one that's messing with this. the jp e-store release jfleve.lgp should read fine now, like the android version. |
If not, inherit what was set via the config
2d256ed
to
709a37a
Compare
@zaphod77 that was never the issue blocking this PR. Read above what was pending for. |
I think zap is referring to what I wrote in the PR summary about field text not working with unmodified flevel unless it’s re-exported with MR. I’ll check later to see if it works. |
I have been testing this PR using the mobile version (extracted from my iOS copy of the game). To start with, I can confirm that, before the recent fix by @zaphod77, field text was completely broken with unmodified flevel, making the game unplayable. Even though it could finally display real Japanese characters, it was making meaningless "words" with them. I am very happy to report that such major problem is completely fixed now. The game plays just fine in Japanese, out of the box. I checked all the main menus, tried different resolutions, 16:9 vs 4:9, loaded different save files and, overall, it seems to be working very well! For the most part, things are correctly aligned and displayed, but there are still some issues (see points 1, 4, and 5).
Something I found, not previously reported:
|
Summary
Adds an option to enable japanese text rendering for the japanese version of the game.
Right now field text only works if the jp flevel is re-exported using Makou Reactor.
Related #39
Motivation
To end the pain of the japanese nation.
ACKs