Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Meteor package be upgraded to 1.2.3? #597

Closed
mitar opened this issue Oct 24, 2015 · 14 comments
Closed

Can Meteor package be upgraded to 1.2.3? #597

mitar opened this issue Oct 24, 2015 · 14 comments

Comments

@mitar
Copy link

mitar commented Oct 24, 2015

It is still 1.2.1.

https://atmospherejs.com/velocityjs/velocityjs

@derwaldgeist
Copy link

+1

It would also be awesome if you could fix the Atmosphere Github link to directly point to the repo for the Meteor package. I was trying to figure out if UI was already included, but can't tell since the Github link points to the core velocity Github repo.

@danielkalen
Copy link

+1

@danielkalen
Copy link

Seems like it's been 20 days since you opened this issue and Julian still didn't update the Meteor package :(
As a temporary solution I've uploaded the 1.2.3 version which is called danielkalen:velocityjs.

@kenwheeler
Copy link
Contributor

@danielkalen I'm the steward of this repo now. How does the meteor version work? I can get it pushed out soon if I know how to do it.

@kenwheeler
Copy link
Contributor

I've typically only used bower and npm

@mitar
Copy link
Author

mitar commented Nov 13, 2015

The links points to this?

But now looking at the content of this repository it is already 1.2.3. So I am not sure if this package is really what is available under velocityjs:velocityjs.

@danielkalen
Copy link

@mitar Here's proof that the current package located on atmospherejs is 1.2.1 http://share.danielkalen.com/2wM/

@danielkalen
Copy link

@kenwheeler You have to download meteor (obviously), and create a package possible using this tutorial: http://www.webtempest.com/meteor-js-packages-tutorial

Basically you need to create the package dir and inside have a package.js (http://docs.meteor.com/#/full/packagejs) describing the behavior of the package, along with the latest version (I think minified) of velocity.

@kenwheeler kenwheeler added this to the 1.2.4 || 2.0.0 milestone Jan 19, 2016
@Rycochet Rycochet modified the milestones: 1.3.1, 1.2.4 || 2.0.0 Aug 13, 2016
@Rycochet Rycochet removed this from the 1.3.1 milestone Sep 20, 2016
@alejandroiglesias
Copy link

Any updates on this? It has been a year since opened and we're still having access to Velocity 1.2.1 from Meteor packages.

@Rycochet
Copy link
Collaborator

I've not had the time to look at it - beyond seeing that the tutorial link is dead - the atmospherejs link is saying 1.3.2 but I'm assuming it's grabbing the readme and not the js files?

If someone wants to put together a Pull Request to add the needed things then it would be helpful :-)

@abernix
Copy link

abernix commented Nov 30, 2016

@Rycochet I'm not familiar with VelocityJS but thought I'd chime on on this and try to help as it was mentioned in a Meteor issue (linked above). As you said, the README is just getting updated from the GitHub README, but the package itself has been stagnant on 1.2.1 since it was initially released.

Ultimately, I'm fairly sure this package isn't critical anymore as Meteor natively supports NPM modules. Though there do seem to be a decent number of legacy users using this Meteor package and Meteor packages are still actively maintained by many, so it's up to you if you want to proceed. I certainly think it can be deprecated in favor of the pure NPM version, but again I'm not familiar with this package.

The process for creating a Meteor package is relatively simple and documented in this official guide: https://guide.meteor.com/writing-atmosphere-packages.html. You would need to install Meteor. It's not difficult, but perhaps a user who is more familiar with the process might more able to help you with it quickly... it appears that @chrismbeckett had originally published the package on Atmosphere, but I'm not sure if they're still involved.

At first glance, it would appear that the Meteor package has never been checked into Git so you may be missing the package source for it which shows how it was laid out. I've gone ahead and attached it here in case it's helpful to anyone.

In your case, the package is already created so you'll just want to bump the versions, reference the most recent versions of the JS and then run meteor publish from that directory. You would need the credentials for the velocityjs org though. Also, I would recommend running it from a sub-directory of the repo and not the top level to avoid bundling unnecessary dependencies (see moment/moment#3531).

Anyhow, those are my two cents. :)

@alejandroiglesias
Copy link

Seems best to use the npm version since it's preferred now over Meteor packages.

@Rycochet
Copy link
Collaborator

@abernix That's really useful, thanks :-)

I'd like to get the Meteor package set to depreciated if possible then - so it uses the NPM package instead - will need to find out who controls the velocityjs organisation first (I'll email around, but people are on holiday right now) - hopefully this issue can be laid to rest soon :-)

@mitar
Copy link
Author

mitar commented Nov 30, 2016

I think velocity is autopublished: MeteorCommunity/discussions#14 (comment)

The issue is that since MDG discontinued meteor.com free hosting, autopublishing does not work anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants