Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a lint configuration file #23

Open
davidanthoff opened this issue Jul 10, 2024 · 2 comments
Open

Add support for a lint configuration file #23

davidanthoff opened this issue Jul 10, 2024 · 2 comments

Comments

@davidanthoff
Copy link
Member

Interesting prior art discussion at https://github.com/rust-lang/rfcs/blob/master/text/3389-manifest-lint.md.

@ufechner7
Copy link
Contributor

Shall it be .yaml or .toml ?

Is there already a list of features that we might want to turn on or off?

@davidanthoff
Copy link
Member Author

There is already a basic implementation for this in the code right now. Essentially it looks for files called .JuliaLint.toml, and then applies those settings to the folder it is in and all children.

Currently it supports these

valid_lint_configs = ["syntax-errors", "syntax-warnings", "testitem-errors", "toml-syntax-errors", "lint-config-errors"]
config values, with a simple true or false.

There are really two things that we need to do here:

  1. Add more config options, in particular configuration options for the legacy lint options that are in StaticLint.jl. As I move SymbolServer and StaticLint into JuliaWorkspaces, that is going to happen as part of that work.
  2. Decide whether the config file format is good :) My gut feeling is that it is probably too simplistic... We might prefer something where there is a rule, and then one can decide whether that should result in an info/warning/error. And maybe also more config options... Just not sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants