From ceed222149b2e0c68a2b64222eca9a7b8bef8bad Mon Sep 17 00:00:00 2001
From: juju4 <juju4@users.noreply.github.com>
Date: Sun, 14 Jul 2024 07:01:42 +0000
Subject: [PATCH] fix(debian-logcheck): set syslog-summary basic replacement
 for Debian11+/Ubuntu22.04+ with extra replace patterns, ensure custom TMP
 exists and correct owner

---
 tasks/debian-logcheck.yml   | 23 +++++++++++++++++++++--
 templates/syslog-summary.j2 | 18 ++++++++++++++++++
 2 files changed, 39 insertions(+), 2 deletions(-)
 create mode 100644 templates/syslog-summary.j2

diff --git a/tasks/debian-logcheck.yml b/tasks/debian-logcheck.yml
index 4ed9d9d..7c5a8f3 100644
--- a/tasks/debian-logcheck.yml
+++ b/tasks/debian-logcheck.yml
@@ -1,4 +1,8 @@
 ---
+# syslog-summary package has been removed after Debian10/Ubuntu20.04
+# and no direct replacement => basic one
+# https://tracker.debian.org/pkg/syslog-summary
+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=198762
 
 - name: Logcheck additional configuration - ntpd ignore
   ansible.builtin.copy:
@@ -48,10 +52,16 @@
     - { regexp: '^#SYSLOGSUMMARY=0', replace: 'SYSLOGSUMMARY=1' }
     - { regexp: '^(#?)TMP=".*"', replace: 'TMP=/tmp/logcheck-temp-files' }
 
-- name: Ensure TMP dir exists
+- name: Ensure TMP dir exists now
+  ansible.builtin.file:
+    path: /tmp/logcheck-temp-files
+    owner: logcheck
+    mode: '0700'
+
+- name: Ensure TMP dir exists at reboot
   ansible.builtin.lineinfile:
     dest: /etc/cron.d/logcheck
-    line: '@reboot         logcheck    [ ! -d /tmp/logcheck-temp-files ] && install -d -m 700 /tmp/logcheck-temp-files'
+    line: '@reboot         logcheck    [ ! -d /tmp/logcheck-temp-files ] && install -d -o logcheck -m 700 /tmp/logcheck-temp-files'
     insertafter: '^@reboot         logcheck    if [ -x /usr/sbin/logcheck ]; then nice -n10 /usr/sbin/logcheck -R; fi'
     mode: '0644'
 
@@ -123,3 +133,12 @@
     mode: '0644'
     create: yes
   when: ansible_service_mgr == 'systemd'
+
+- name: Add basic replacement for syslog-summary if no package
+  ansible.builtin.template:
+    src: syslog-summary.j2
+    dest: /usr/bin/syslog-summary
+    mode: '0755'
+  when: >
+    (ansible_distribution == 'Debian' and ansible_distribution_major_version|int > 10) or
+    (ansible_distribution == 'Ubuntu' and ansible_distribution_major_version|int > 20)
diff --git a/templates/syslog-summary.j2 b/templates/syslog-summary.j2
new file mode 100644
index 0000000..a933920
--- /dev/null
+++ b/templates/syslog-summary.j2
@@ -0,0 +1,18 @@
+#!/bin/sh
+{{ ansible_managed }}
+# /usr/bin/syslog-summary
+# Basic replacement for dead package...
+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=198762
+
+for f in $*; do
+  if [ -r "$f" ]; then
+    list_files="$list_files $f";
+  else
+    no_files="$no_files $f"
+  fi
+done
+cat ${list_files} | sort | uniq -c | sort -nr | tee /tmp/syslog-summary.bak
+
+if [ "X${no_files}" != "X " ]; then
+>&2 echo "Warning: following syslog-summary arguments are not files or not readable: $no_files"
+fi