From 1e8af591be121ec5981062d1db15a64b1d773835 Mon Sep 17 00:00:00 2001 From: Thomas Miller Date: Wed, 2 Nov 2022 10:51:10 +0100 Subject: [PATCH 1/2] Updates juju works to Go 1.19 Upgrading the juju/workers package to use Go 1.19 to fall in line with the main source tree version. Also ran go mod tidy to generate an up to date go.sum as it had not been run for some time and contained a lot of unused packages. --- go.mod | 2 +- go.sum | 60 ---------------------------------------------------------- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/go.mod b/go.mod index f690661..e5e78da 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/juju/worker/v3 -go 1.17 +go 1.19 require ( github.com/juju/clock v0.0.0-20220203021603-d9deb868a28a diff --git a/go.sum b/go.sum index ce9b86d..3440b6a 100644 --- a/go.sum +++ b/go.sum @@ -1,34 +1,15 @@ -github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e/go.mod h1:chxPXzSsl7ZWRAuOIE23GDNzjWuZquvFlgA8xmpunjU= -github.com/ChrisTrenkamp/goxpath v0.0.0-20210404020558-97928f7e12b6/go.mod h1:nuWgzSkT5PnyOd+272uUmV0dnAnAn42Mk7PiQC5VzN4= github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E= -github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= -github.com/gofrs/uuid v4.2.0+incompatible/go.mod h1:b2aQJv3Z4Fp6yNu3cdSllBxTCLRxnplIgP/c0N/04lM= -github.com/golang/mock v1.5.0/go.mod h1:CWnOUgYIOo4TcNZ0wHX3YZCqsaM1I1Jvs6v3mP3KVu8= -github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= -github.com/gorilla/securecookie v1.1.1/go.mod h1:ra0sb63/xPlUeL+yeDciTfxMRAA+MP+HVt/4epWDjd4= -github.com/gorilla/sessions v1.2.1/go.mod h1:dk2InVEVJ0sfLlnXv9EAgkf6ecYs/i80K/zI+bUmuGM= -github.com/hashicorp/go-uuid v1.0.2/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro= -github.com/jcmturner/aescts/v2 v2.0.0/go.mod h1:AiaICIRyfYg35RUkr8yESTqvSy7csK90qZ5xfvvsoNs= -github.com/jcmturner/dnsutils/v2 v2.0.0/go.mod h1:b0TnjGOvI/n42bZa+hmXL+kFJZsFT7G4t3HTlQ184QM= -github.com/jcmturner/gofork v1.0.0/go.mod h1:MK8+TM0La+2rjBD4jE12Kj1pCCxK7d2LK/UM3ncEo0o= -github.com/jcmturner/goidentity/v6 v6.0.1/go.mod h1:X1YW3bgtvwAXju7V3LCIMpY0Gbxyjn/mY9zx4tFonSg= -github.com/jcmturner/gokrb5/v8 v8.4.2/go.mod h1:sb+Xq/fTY5yktf/VxLsE3wlfPqQjp0aWNYyvBVK62bc= -github.com/jcmturner/rpc/v2 v2.0.3/go.mod h1:VUJYCIDm3PVOEHw8sgt091/20OJjskO/YJki3ELg/Hc= github.com/juju/ansiterm v0.0.0-20160907234532-b99631de12cf/go.mod h1:UJSiEoRfvx3hP73CvoARgeLjaIOjybY9vj8PUPPFGeU= github.com/juju/ansiterm v0.0.0-20180109212912-720a0952cc2a/go.mod h1:UJSiEoRfvx3hP73CvoARgeLjaIOjybY9vj8PUPPFGeU= -github.com/juju/ansiterm v0.0.0-20210706145210-9283cdf370b5/go.mod h1:UJSiEoRfvx3hP73CvoARgeLjaIOjybY9vj8PUPPFGeU= github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c/go.mod h1:nD0vlnrUjcjJhqN5WuCWZyzfd5AHZAC9/ajvbSx69xA= -github.com/juju/clock v0.0.0-20220202072423-1b0f830854c4/go.mod h1:zDZCPSgCJQINeZtQwHx2/cFk4seaBC8Yiqe8V82xiP0= github.com/juju/clock v0.0.0-20220203021603-d9deb868a28a h1:Az/6CM/P5guGHNy7r6TkOCctv3lDmN3W1uhku7QMupk= github.com/juju/clock v0.0.0-20220203021603-d9deb868a28a/go.mod h1:GZ/FY8Cqw3KHG6DwRVPUKbSPTAwyrU28xFi5cqZnLsc= github.com/juju/cmd v0.0.0-20171107070456-e74f39857ca0/go.mod h1:yWJQHl73rdSX4DHVKGqkAip+huBslxRwS8m9CrOLq18= -github.com/juju/cmd/v3 v3.0.0-20220202061353-b1cc80b193b0/go.mod h1:EoGJiEG+vbMwO9l+Es0SDTlaQPjH6nLcnnc4NfZB3cY= github.com/juju/collections v0.0.0-20200605021417-0d0ec82b7271/go.mod h1:5XgO71dV1JClcOJE+4dzdn4HrI5LiyKd7PlVG6eZYhY= github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a h1:d7eZO8OS/ZXxdP0uq3E8CdoA1qNFaecAv90UxrxaY2k= github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a/go.mod h1:JWeZdyttIEbkR51z2S13+J+aCuHVe0F6meRy+P0YGDo= github.com/juju/errors v0.0.0-20150916125642-1b5e39b83d18/go.mod h1:W54LbzXuIE0boCoNJfwqpmkKJ1O4TCTZMetAt6jGk7Q= github.com/juju/errors v0.0.0-20200330140219-3fe23663418f/go.mod h1:W54LbzXuIE0boCoNJfwqpmkKJ1O4TCTZMetAt6jGk7Q= -github.com/juju/errors v0.0.0-20210818161939-5560c4c073ff/go.mod h1:i1eL7XREII6aHpQ2gApI/v6FkVUDEBremNkcBCKYAcY= github.com/juju/errors v0.0.0-20220203013757-bd733f3c86b9 h1:EJHbsNpQyupmMeWTq7inn+5L/WZ7JfzCVPJ+DP9McCQ= github.com/juju/errors v0.0.0-20220203013757-bd733f3c86b9/go.mod h1:TRm7EVGA3mQOqSVcBySRY7a9Y1/gyVhh/WTCnc5sD4U= github.com/juju/gnuflag v0.0.0-20171113085948-2ce1bb71843d/go.mod h1:2PavIy+JPciBPrBUjwbNvtwB6RQlve+hkpll6QSNmOE= @@ -40,33 +21,25 @@ github.com/juju/loggo v0.0.0-20210728185423-eebad3a902c4/go.mod h1:NIXFioti1SmKA github.com/juju/mgo/v2 v2.0.0-20210302023703-70d5d206e208 h1:/WiCm+Vpj87e4QWuWwPD/bNE9kDrWCLvPBHOQNcG2+A= github.com/juju/mgo/v2 v2.0.0-20210302023703-70d5d206e208/go.mod h1:0OChplkvPTZ174D2FYZXg4IB9hbEwyHkD+zT+/eK+Fg= github.com/juju/mutex v0.0.0-20171110020013-1fe2a4bf0a3a/go.mod h1:Y3oOzHH8CQ0Ppt0oCKJ2JFO81/EsWenH5AEqigLH+yY= -github.com/juju/mutex/v2 v2.0.0-20220128011612-57176ebdcfa3/go.mod h1:TTCG9BJD9rCC4DZFz3jA0QvCqFDHw8Eqz0jstwY7RTQ= github.com/juju/retry v0.0.0-20151029024821-62c620325291/go.mod h1:OohPQGsr4pnxwD5YljhQ+TZnuVRYpa5irjugL1Yuif4= github.com/juju/retry v0.0.0-20180821225755-9058e192b216 h1:/eQL7EJQKFHByJe3DeE8Z36yqManj9UY5zppDoQi4FU= github.com/juju/retry v0.0.0-20180821225755-9058e192b216/go.mod h1:OohPQGsr4pnxwD5YljhQ+TZnuVRYpa5irjugL1Yuif4= github.com/juju/testing v0.0.0-20180402130637-44801989f0f7/go.mod h1:63prj8cnj0tU0S9OHjGJn+b1h0ZghCndfnbQolrYTwA= -github.com/juju/testing v0.0.0-20180517134105-72703b1e95eb/go.mod h1:63prj8cnj0tU0S9OHjGJn+b1h0ZghCndfnbQolrYTwA= github.com/juju/testing v0.0.0-20190723135506-ce30eb24acd2/go.mod h1:63prj8cnj0tU0S9OHjGJn+b1h0ZghCndfnbQolrYTwA= github.com/juju/testing v0.0.0-20210302031854-2c7ee8570c07/go.mod h1:7lxZW0B50+xdGFkvhAb8bwAGt6IU87JB1H9w4t8MNVM= -github.com/juju/testing v0.0.0-20210324180055-18c50b0c2098/go.mod h1:7lxZW0B50+xdGFkvhAb8bwAGt6IU87JB1H9w4t8MNVM= -github.com/juju/testing v0.0.0-20220202055744-1ad0816210a6/go.mod h1:QgWc2UdIPJ8t3rnvv95tFNOsQDfpXYEZDbP281o3b2c= github.com/juju/testing v0.0.0-20220203020004-a0ff61f03494 h1:XEDzpuZb8Ma7vLja3+5hzUqVTvAqm5Y+ygvnDs5iTMM= github.com/juju/testing v0.0.0-20220203020004-a0ff61f03494/go.mod h1:rUquetT0ALL48LHZhyRGvjjBH8xZaZ8dFClulKK5wK4= github.com/juju/utils v0.0.0-20180424094159-2000ea4ff043/go.mod h1:6/KLg8Wz/y2KVGWEpkK9vMNGkOnu4k/cqs8Z1fKjTOk= -github.com/juju/utils v0.0.0-20200116185830-d40c2fe10647 h1:wQpkHVbIIpz1PCcLYku9KFWsJ7aEMQXHBBmLy3tRBTk= github.com/juju/utils v0.0.0-20200116185830-d40c2fe10647/go.mod h1:6/KLg8Wz/y2KVGWEpkK9vMNGkOnu4k/cqs8Z1fKjTOk= github.com/juju/utils/v2 v2.0.0-20200923005554-4646bfea2ef1/go.mod h1:fdlDtQlzundleLLz/ggoYinEt/LmnrpNKcNTABQATNI= -github.com/juju/utils/v3 v3.0.0-20220130232349-cd7ecef0e94a/go.mod h1:LzwbbEN7buYjySp4nqnti6c6olSqRXUk6RkbSUUP1n8= github.com/juju/utils/v3 v3.0.0-20220202114721-338bb0530e89 h1:AabsPzXjiUEs53myZfvZ62h+QZKDpsEAYKaW0IEgURU= github.com/juju/utils/v3 v3.0.0-20220202114721-338bb0530e89/go.mod h1:wf5w+8jyTh2IYnSX0sHnMJo4ZPwwuiBWn+xN3DkQg4k= github.com/juju/version v0.0.0-20161031051906-1f41e27e54f2/go.mod h1:kE8gK5X0CImdr7qpSKl3xB2PmpySSmfj7zVbkZFs81U= github.com/juju/version v0.0.0-20180108022336-b64dbd566305/go.mod h1:kE8gK5X0CImdr7qpSKl3xB2PmpySSmfj7zVbkZFs81U= -github.com/juju/version v0.0.0-20191219164919-81c1be00b9a6 h1:nrqc9b4YKpKV4lPI3GPPFbo5FUuxkWxgZE2Z8O4lgaw= github.com/juju/version v0.0.0-20191219164919-81c1be00b9a6/go.mod h1:kE8gK5X0CImdr7qpSKl3xB2PmpySSmfj7zVbkZFs81U= github.com/juju/version/v2 v2.0.0-20211007103408-2e8da085dc23 h1:wtEPbidt1VyHlb8RSztU6ySQj29FLsOQiI9XiJhXDM4= github.com/juju/version/v2 v2.0.0-20211007103408-2e8da085dc23/go.mod h1:Ljlbryh9sYaUSGXucslAEDf0A2XUSGvDbHJgW8ps6nc= github.com/julienschmidt/httprouter v1.1.1-0.20151013225520-77a895ad01eb/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7VTCxuUUipMqKk8s4w= -github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo= github.com/kr/pretty v0.2.1 h1:Fmg33tUaq4/8ym9TJN1x7sLJnHVwhP33CNkpYV/7rwI= github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI= github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= @@ -74,66 +47,35 @@ github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY= github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE= github.com/lunixbochs/vtclean v0.0.0-20160125035106-4fbf7632a2c6/go.mod h1:pHhQNgMf3btfWnGBVipUOjRYhoOsdGqdm/+2c2E2WMI= -github.com/lunixbochs/vtclean v1.0.0/go.mod h1:pHhQNgMf3btfWnGBVipUOjRYhoOsdGqdm/+2c2E2WMI= github.com/masterzen/azure-sdk-for-go v3.2.0-beta.0.20161014135628-ee4f0065d00c+incompatible/go.mod h1:mf8fjOu33zCqxUjuiU3I8S1lJMyEAlH+0F2+M5xl3hE= github.com/masterzen/simplexml v0.0.0-20160608183007-4572e39b1ab9/go.mod h1:kCEbxUJlNDEBNbdQMkPSp6yaKcRXVI6f4ddk8Riv4bc= -github.com/masterzen/simplexml v0.0.0-20190410153822-31eea3082786/go.mod h1:kCEbxUJlNDEBNbdQMkPSp6yaKcRXVI6f4ddk8Riv4bc= github.com/masterzen/winrm v0.0.0-20161014151040-7a535cd943fc/go.mod h1:CfZSN7zwz5gJiFhZJz49Uzk7mEBHIceWmbFmYx7Hf7E= -github.com/masterzen/winrm v0.0.0-20211231115050-232efb40349e/go.mod h1:Iju3u6NzoTAvjuhsGCZc+7fReNnr/Bd6DsWj3WTokIU= github.com/masterzen/xmlpath v0.0.0-20140218185901-13f4951698ad/go.mod h1:A0zPC53iKKKcXYxr4ROjpQRQ5FgJXtelNdSmHHuq/tY= github.com/mattn/go-colorable v0.0.6/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaOChaDxuIBZU= -github.com/mattn/go-colorable v0.1.8/go.mod h1:u6P/XSegPjTcexA+o6vUJrdnUu04hMope9wVRipJSqc= github.com/mattn/go-isatty v0.0.0-20160806122752-66b8e73f3f5c/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4= -github.com/mattn/go-isatty v0.0.12/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU= -github.com/mattn/go-isatty v0.0.13/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU= github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d/go.mod h1:YUTz3bUH2ZwIWBy3CJBeOBEugqcmXREj14T+iG/4k4U= -github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= -github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= -github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= -github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= golang.org/x/crypto v0.0.0-20180214000028-650f4a345ab4/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= -golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= -golang.org/x/crypto v0.0.0-20201112155050-0c6587e931a9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= -golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 h1:0es+/5331RGQPcXlMfP+WrnIIS6dNnNRe0WB02W0F4M= golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= -golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/net v0.0.0-20180406214816-61147c48b25b/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= -golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= -golang.org/x/net v0.0.0-20200114155413-6afb5195e5aa/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= golang.org/x/net v0.0.0-20200904194848-62affa334b73/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA= golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg= -golang.org/x/net v0.0.0-20210805182204-aaa1db679c0d/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= -golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/net v0.0.0-20211216030914-fe4d6282115f h1:hEYJvxw1lSnWIl8X9ofsYMklzaDs90JI2az5YMd4fPM= golang.org/x/net v0.0.0-20211216030914-fe4d6282115f/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= -golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.0.0-20210806184541-e5e7981a1069/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= -golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= -golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ= golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= -golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= -golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= -golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= -golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v1.0.0-20160105164936-4f90aeace3a2/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= -gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q= gopkg.in/errgo.v1 v1.0.0-20161222125816-442357a80af5/go.mod h1:u0ALmqvLRxLI95fkdCEWrE6mhWYZW1aMOJHp5YXLHTg= @@ -144,10 +86,8 @@ gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWD gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637 h1:yiW+nvdHb9LVqSHQBXfZCieqV4fzYhNBql77zY0ykqs= gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637/go.mod h1:BHsqpu/nsuzkT5BpiH1EMZPLyqSMM8JbIavyFACoFNk= gopkg.in/yaml.v2 v2.0.0-20170712054546-1be3d31502d6/go.mod h1:JAlM8MvJe8wmxCU4Bli9HhUf9+ttbYbLASfIpnQbh74= -gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY= gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ= -gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= launchpad.net/gocheck v0.0.0-20140225173054-000000000087/go.mod h1:hj7XX3B/0A+80Vse0e+BUHsHMTEhd0O4cpUHr/e/BUM= launchpad.net/xmlpath v0.0.0-20130614043138-000000000004/go.mod h1:vqyExLOM3qBx7mvYRkoxjSCF945s0mbe7YynlKYXtsA= From 7bc5a20bb9b463d5605d9d860a782a9f547c3bc5 Mon Sep 17 00:00:00 2001 From: Thomas Miller Date: Wed, 2 Nov 2022 14:05:02 +0100 Subject: [PATCH 2/2] Updates worker package to latest juju errors. We are updating the worker package to take advantage of new changes available in the Juju errors package. Specifically this affords ConstError, Is and As support. We want this so packages that rely on this one such as Juju can pass heavily wrapped errors and still have the same side effect in this package. The example here is that at the moment Juju can't wrap error's from this package such as uninstall as this library won't handle the case correctly as the error gets lost in Cause. --- catacomb/catacomb.go | 6 +++--- catacomb/catacomb_test.go | 10 ++++------ dependency/engine.go | 28 +++++++++++++++------------- dependency/engine_test.go | 4 ++-- dependency/interface.go | 36 +++++++++++++++++++----------------- go.mod | 2 +- go.sum | 4 ++-- runner.go | 12 ++++++------ runner_test.go | 6 +++--- 9 files changed, 55 insertions(+), 53 deletions(-) diff --git a/catacomb/catacomb.go b/catacomb/catacomb.go index ce45bd3..67ff35a 100644 --- a/catacomb/catacomb.go +++ b/catacomb/catacomb.go @@ -223,9 +223,9 @@ func (catacomb *Catacomb) Kill(err error) { if err == tomb.ErrDying { err = errors.New("bad catacomb Kill: tomb.ErrDying") } - cause := errors.Cause(err) - if match, ok := cause.(dyingError); ok { - if catacomb != match.catacomb { + var dyingErr dyingError + if errors.As(err, &dyingErr) { + if catacomb != dyingErr.catacomb { err = errors.Errorf("bad catacomb Kill: other catacomb's ErrDying") } else { err = tomb.ErrDying diff --git a/catacomb/catacomb_test.go b/catacomb/catacomb_test.go index e5f89fc..eae770a 100644 --- a/catacomb/catacomb_test.go +++ b/catacomb/catacomb_test.go @@ -245,7 +245,7 @@ func (s *CatacombSuite) TestAddWhenDyingReturnsWorkerError(c *gc.C) { s.fix.catacomb.Kill(nil) actual := s.fix.catacomb.Add(w) - c.Assert(errors.Cause(actual), gc.Equals, expect) + c.Assert(errors.Is(actual, expect), jc.IsTrue) w.assertDead(c) }) c.Check(err, jc.ErrorIsNil) @@ -267,7 +267,7 @@ func (s *CatacombSuite) TestAddWhenDeadReturnsWorkerError(c *gc.C) { expect := errors.New("squelch") w := s.fix.startErrorWorker(c, expect) actual := s.fix.catacomb.Add(w) - c.Assert(errors.Cause(actual), gc.Equals, expect) + c.Assert(errors.Is(actual, expect), jc.IsTrue) w.assertDead(c) } @@ -394,8 +394,7 @@ func (s *CatacombSuite) TestStressAddKillRaces(c *gc.C) { // the important thing is that it already exists so we can hit // Add() as soon as possible, just like the Kill() below. if err := s.fix.catacomb.Add(w); err != nil { - cause := errors.Cause(err) - c.Check(cause, gc.Equals, errFailed) + c.Check(errors.Is(err, errFailed), jc.IsTrue) } }) together(func() { @@ -407,8 +406,7 @@ func (s *CatacombSuite) TestStressAddKillRaces(c *gc.C) { close(block) wg.Wait() }) - cause := errors.Cause(err) - c.Check(cause, gc.Equals, errFailed) + c.Check(errors.Is(err, errFailed), jc.IsTrue) } func (s *CatacombSuite) TestReusedCatacomb(c *gc.C) { diff --git a/dependency/engine.go b/dependency/engine.go index 1084208..0a518e1 100644 --- a/dependency/engine.go +++ b/dependency/engine.go @@ -491,7 +491,9 @@ func (engine *Engine) context(name string, inputs []string, abort <-chan struct{ } } -var errAborted = errors.New("aborted before delay elapsed") +const ( + errAborted = errors.ConstError("aborted before delay elapsed") +) // runWorker starts the supplied manifold's worker and communicates it back to the // loop goroutine; waits for worker completion; and communicates any error encountered @@ -520,10 +522,10 @@ func (engine *Engine) runWorker(name string, delay time.Duration, start StartFun startWorkerAndWait := func() error { worker, err := startAfterDelay() - switch errors.Cause(err) { - case errAborted: + switch { + case errors.Is(err, errAborted): return errAborted - case nil: + case err == nil: engine.config.Logger.Tracef("running %q manifold worker", name) default: return err @@ -596,18 +598,18 @@ func (engine *Engine) gotStopped(name string, err error, resourceLog []resourceA // Copy current info and check for reasons to stop the engine. info := engine.current[name] - switch errors.Cause(err) { - case nil: + switch { + case err == nil: engine.config.Logger.Debugf("%q manifold worker completed successfully", name) info.recentErrors = 0 - case errAborted: + case errors.Is(err, errAborted): // The start attempt was aborted, so we haven't really started. engine.config.Logger.Tracef("%q manifold worker bounced while starting", name) // If we have been aborted while trying to start, we are more likely // to be able to start, so reset the start attempts. info.startAttempts = 0 info.recentErrors = 1 - case ErrMissing: + case errors.Is(err, ErrMissing): engine.config.Logger.Tracef("%q manifold worker failed to start: %v", name, err) // missing a dependency does (not?) trigger exponential backoff info.recentErrors = 1 @@ -661,19 +663,19 @@ func (engine *Engine) gotStopped(name string, err error, resourceLog []resourceA engine.requestStart(name, engine.config.BounceDelay) } else { // If we didn't stop it ourselves, we need to interpret the error. - switch errors.Cause(err) { - case nil, errAborted: + switch { + case err == nil, errors.Is(err, errAborted): // Nothing went wrong; the task completed successfully. Nothing // needs to be done (unless the inputs change, in which case it // gets to check again). - case ErrMissing: + case errors.Is(err, ErrMissing): // The task can't even start with the current state. Nothing more // can be done (until the inputs change, in which case we retry // anyway). - case ErrBounce: + case errors.Is(err, ErrBounce): // The task exited but wanted to restart immediately. engine.requestStart(name, engine.config.BounceDelay) - case ErrUninstall: + case errors.Is(err, ErrUninstall): // The task should never run again, and can be removed completely. engine.uninstall(name) default: diff --git a/dependency/engine_test.go b/dependency/engine_test.go index e984fb2..bd96208 100644 --- a/dependency/engine_test.go +++ b/dependency/engine_test.go @@ -168,7 +168,7 @@ func (s *EngineSuite) TestStartGetUndeclaredName(c *gc.C) { err = engine.Install("other-task", dependency.Manifold{ Start: func(context dependency.Context) (worker.Worker, error) { err := context.Get("some-task", nil) - c.Check(errors.Cause(err), gc.Equals, dependency.ErrMissing) + c.Check(errors.Is(err, dependency.ErrMissing), jc.IsTrue) c.Check(err, gc.ErrorMatches, `"some-task" not declared: dependency not available`) close(done) // Return a real worker so we don't keep restarting and potentially double-closing. @@ -665,7 +665,7 @@ func (s *EngineSuite) TestWorstError(c *gc.C) { mh2.InjectError(c, errors.New("pong")) err = workertest.CheckKilled(c, engine) - c.Check(errors.Cause(err), gc.Equals, worstErr) + c.Check(errors.Is(err, worstErr), jc.IsTrue) c.Check(callCount, gc.Equals, 2) }) } diff --git a/dependency/interface.go b/dependency/interface.go index 0e7cb7d..b1fadad 100644 --- a/dependency/interface.go +++ b/dependency/interface.go @@ -111,23 +111,6 @@ type Context interface { // not be called again until its declared inputs change. type StartFunc func(context Context) (worker.Worker, error) -// ErrMissing can be returned by a StartFunc or a worker to indicate to -// the engine that it can't be usefully restarted until at least one of its -// dependencies changes. There's no way to specify *which* dependency you need, -// because that's a lot of implementation hassle for little practical gain. -var ErrMissing = errors.New("dependency not available") - -// ErrBounce can be returned by a StartFunc or a worker to indicate to -// the engine that it should be restarted immediately, instead of -// waiting for ErrorDelay. This is useful for workers which restart -// themselves to alert dependents that an output has changed. -var ErrBounce = errors.New("restart immediately") - -// ErrUninstall can be returned by a StartFunc or a worker to indicate to the -// engine that it can/should never run again, and that the originating manifold -// should be completely removed. -var ErrUninstall = errors.New("resource permanently unavailable") - // FilterFunc is an error conversion function for errors returned from workers // or StartFuncs. type FilterFunc func(error) error @@ -145,3 +128,22 @@ type IsFatalFunc func(err error) bool // WorstErrorFunc is used to rank fatal errors, to allow an Engine to return the // single most important error it's encountered. type WorstErrorFunc func(err0, err1 error) error + +const ( + // ErrBounce can be returned by a StartFunc or a worker to indicate to + // the engine that it should be restarted immediately, instead of + // waiting for ErrorDelay. This is useful for workers which restart + // themselves to alert dependents that an output has changed. + ErrBounce = errors.ConstError("restart immediately") + + // ErrMissing can be returned by a StartFunc or a worker to indicate to + // the engine that it can't be usefully restarted until at least one of its + // dependencies changes. There's no way to specify *which* dependency you need, + // because that's a lot of implementation hassle for little practical gain. + ErrMissing = errors.ConstError("dependency not available") + + // ErrUninstall can be returned by a StartFunc or a worker to indicate to the + // engine that it can/should never run again, and that the originating manifold + // should be completely removed. + ErrUninstall = errors.ConstError("resource permanently unavailable") +) diff --git a/go.mod b/go.mod index e5e78da..dfa741f 100644 --- a/go.mod +++ b/go.mod @@ -5,7 +5,7 @@ go 1.19 require ( github.com/juju/clock v0.0.0-20220203021603-d9deb868a28a github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a - github.com/juju/errors v0.0.0-20220203013757-bd733f3c86b9 + github.com/juju/errors v1.0.0 github.com/juju/loggo v0.0.0-20210728185423-eebad3a902c4 github.com/juju/testing v0.0.0-20220203020004-a0ff61f03494 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c diff --git a/go.sum b/go.sum index 3440b6a..2f47bc2 100644 --- a/go.sum +++ b/go.sum @@ -10,8 +10,8 @@ github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a h1:d7eZO8OS/ZXxdP github.com/juju/collections v0.0.0-20220203020748-febd7cad8a7a/go.mod h1:JWeZdyttIEbkR51z2S13+J+aCuHVe0F6meRy+P0YGDo= github.com/juju/errors v0.0.0-20150916125642-1b5e39b83d18/go.mod h1:W54LbzXuIE0boCoNJfwqpmkKJ1O4TCTZMetAt6jGk7Q= github.com/juju/errors v0.0.0-20200330140219-3fe23663418f/go.mod h1:W54LbzXuIE0boCoNJfwqpmkKJ1O4TCTZMetAt6jGk7Q= -github.com/juju/errors v0.0.0-20220203013757-bd733f3c86b9 h1:EJHbsNpQyupmMeWTq7inn+5L/WZ7JfzCVPJ+DP9McCQ= -github.com/juju/errors v0.0.0-20220203013757-bd733f3c86b9/go.mod h1:TRm7EVGA3mQOqSVcBySRY7a9Y1/gyVhh/WTCnc5sD4U= +github.com/juju/errors v1.0.0 h1:yiq7kjCLll1BiaRuNY53MGI0+EQ3rF6GB+wvboZDefM= +github.com/juju/errors v1.0.0/go.mod h1:B5x9thDqx0wIMH3+aLIMP9HjItInYWObRovoCFM5Qe8= github.com/juju/gnuflag v0.0.0-20171113085948-2ce1bb71843d/go.mod h1:2PavIy+JPciBPrBUjwbNvtwB6RQlve+hkpll6QSNmOE= github.com/juju/httpprof v0.0.0-20141217160036-14bf14c30767/go.mod h1:+MaLYz4PumRkkyHYeXJ2G5g5cIW0sli2bOfpmbaMV/g= github.com/juju/loggo v0.0.0-20170605014607-8232ab8918d9/go.mod h1:vgyd7OREkbtVEN/8IXZe5Ooef3LQePvuBm9UWj6ZL8U= diff --git a/runner.go b/runner.go index 3f15ff0..3c0ae1a 100644 --- a/runner.go +++ b/runner.go @@ -13,13 +13,13 @@ import ( "gopkg.in/tomb.v2" ) -// DefaultRestartDelay holds the default length of time that a worker -// will wait between exiting and being restarted by a Runner. -const DefaultRestartDelay = 3 * time.Second +const ( + // DefaultRestartDelay holds the default length of time that a worker + // will wait between exiting and being restarted by a Runner. + DefaultRestartDelay = 3 * time.Second -var ( - ErrAborted = errors.New("aborted waiting for worker") - ErrDead = errors.New("worker runner is not running") + ErrAborted = errors.ConstError("aborted waiting for worker") + ErrDead = errors.ConstError("worker runner is not running") ) // Runner runs a set of workers, restarting them as necessary diff --git a/runner_test.go b/runner_test.go index c3839c2..5212bb6 100644 --- a/runner_test.go +++ b/runner_test.go @@ -190,7 +190,7 @@ func (*RunnerSuite) TestStopAndWaitWorkerWithAbort(c *gc.C) { close(stop) select { case err := <-errc: - c.Assert(errors.Cause(err), gc.Equals, worker.ErrAborted) + c.Assert(errors.Is(err, worker.ErrAborted), jc.IsTrue) case <-time.After(longWait): c.Fatalf("timed out waiting for worker") } @@ -562,7 +562,7 @@ func (*RunnerSuite) TestWorkerWithAbort(c *gc.C) { close(stop) select { case err := <-errc: - c.Assert(errors.Cause(err), gc.Equals, worker.ErrAborted) + c.Assert(errors.Is(err, worker.ErrAborted), jc.IsTrue) case <-time.After(longWait): c.Fatalf("timed out waiting for worker") } @@ -651,7 +651,7 @@ func (*RunnerSuite) TestWorkerWhenRunnerKilledWhileWaiting(c *gc.C) { runner.Kill() select { case err := <-errc: - c.Assert(errors.Cause(err), gc.Equals, worker.ErrDead) + c.Assert(errors.Is(err, worker.ErrDead), jc.IsTrue) case <-time.After(longWait): c.Fatalf("timed out waiting for worker") }