Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

README does not match pod_spec_set failure implementation #22

Open
stub42 opened this issue Aug 22, 2019 · 0 comments
Open

README does not match pod_spec_set failure implementation #22

stub42 opened this issue Aug 22, 2019 · 0 comments

Comments

@stub42
Copy link
Contributor

stub42 commented Aug 22, 2019

The README has pod_spec_set returning a boolean error to indicate success or failure. The implementation has it raising a subprocess.CalledProcessError on failure.

pod_spec_set should either return a boolean as documented, or raise a specific exception rather than a generic CalledProcessError (which is a leaky abstraction of the underlying pod-spec-set hook environment tool)

weiiwang01 pushed a commit to canonical/wordpress-k8s-operator that referenced this issue Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant