Build fails with Go 1.23

[stefanb]

What happened:

Build with Go 1.23 rc1 & rc2 fails.

What you expected to happen:

Build to succeed.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?

Build error

  ...
  # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame
  make: *** [juicefs] Error 1

Indicating the upstream problems

• godeltaprof tests are failing on gotip grafana/pyroscope-go#103
• runtime: MutexProfile has multiple records with equal stack golang/go#67548

The upstream fixes still needs to be released.

Environment:

• JuiceFS version (use juicefs --version) or Hadoop Java SDK version: 1.2.0
• Cloud provider or hardware configuration running JuiceFS:
• OS (e.g cat /etc/os-release):
• Kernel (e.g. uname -a):
• Object storage (cloud provider and region, or self maintained):
• Metadata engine info (version, cloud provider managed or self maintained):
• Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
• Others:
  • Build attempt go 1.23, [email protected] 1.22.6 (new formula) Homebrew/homebrew-core#175310
  • Formula: https://github.com/Homebrew/homebrew-core/blob/master/Formula/j/juicefs.rb
  • Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see
  • Go 1.23 release notes: https://tip.golang.org/doc/go1.23#linker
  • Proposal: cmd/link: lock down future uses of linkname golang/go#67401

[zhijian-pro]

Thanks, we will fix our code after the upstream fixes

[stefanb]

FYI, upstream pyroscope-go has released a fix for Go 1.23:
https://github.com/grafana/pyroscope-go/releases/tag/godeltaprof%2Fv0.1.8