-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Unable to format CSI volumes on Nomad using juicefs-csi-driver >= v0.23.3 #1116
Comments
try URL Encoding for metaurl |
Hi @zxh326 , are you saying the |
pre-escape if |
Hi, I am still not following, sorry. The
Which has a password of |
yes! could you try changing |
Okay, I gave that a try, and while it doesn't seem to error out on the formatting of
|
can you check
|
I noticed that your other PR has the same metaurl, but it can be mount normally |
Yes, this is accessible from the container (I have a custom juicefs-csi-driver image I run that bypasses the escaping, and the volume can get formatted and mounted just fine). I ran the command manually after Let me know if you need anything else. Failure
SuccessUsing my custom image, if I re-run the command with the
|
FWIW, I switched to
|
What happened:
I deployed the latest version of the CSI image for Controller and Node (v0.24.7), and created a volume. That all worked fine.
However, when I then deployed a Nomad Job that mounts that previously created CSI volume, the Node job threw a series of errors:
What you expected to happen:
Format and mount using Nomad CSI works fine.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?
Environment:
kubectl version
):Additional Information
I dug around a little bit, and I think the v0.23.3 has a fix in place for #843 that introduced a regression.
Speciifcally, there is a lot going on in the
ceFormat
func, however, I think around L965, the text${metaurl}
is getting escaped to$'<whatever your metaurl text is>'
, which obvisouly won't work, as reported by L998 just a bit later, after the command is invoked.I would take a stab at submitting a PR, however, there's some stuff going on that I'm not entirely sure about--namely why
cmdArgs
+args
are declared (L934 + L935) and filled with identical information, butcmdArgs
is never actually used anywhere except logging statements (from what I can tell)--maybe it's a different codepath force
vsee
versions? The actual invocation of the cmd happens on L988 usingargs
only.At any rate, I'm happy to help submit a PR, if it would be useful. Thank you!
The text was updated successfully, but these errors were encountered: