Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection mode transfer protocol J1939-21 #49

Open
sheckey opened this issue Sep 25, 2023 · 0 comments
Open

Connection mode transfer protocol J1939-21 #49

sheckey opened this issue Sep 25, 2023 · 0 comments

Comments

@sheckey
Copy link

sheckey commented Sep 25, 2023

The send_pgn() argument list does not appear to support sending a connection mode transfer to a destination address other than what is also specified for the PGN to be transferred. For example, in this request to send message, the destination address is 0x1C and the PGN of the transfer is 0xFF73:

r xtd 02 18EC1C03 08 10 70 00 10 10 73 FF 00 0 0 10.533150 0.114073 .p...s.. TP.CM RTS - JD Product Identification

With the library as it is, we cannot specify 0x1C separately from 0xFF73 , but only PDU format and specific which goes in both places: the CAN ID and the message body. I have hacked an easy solution, but would like to discuss this to see if I am incorrect, or using it incorrectly, or if you would like to me to try and make a pull request to help out.

Thank you for making this wonderful library available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant