-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom root component tag. #46
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments inline
package.json
Outdated
@@ -1,9 +1,12 @@ | |||
{ | |||
"name": "react-typist", | |||
"version": "2.0.4", | |||
"version": "2.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove these changes? I'll update the version when I publish a new version separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in my last commit. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put back the version to 2.0.4. Thank you for accepting my merge!
package.json
Outdated
@@ -1,9 +1,12 @@ | |||
{ | |||
"name": "react-typist", | |||
"version": "2.0.4", | |||
"version": "2.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in my last commit. Thank you
Hi @jstejada, are my changes ok? |
Added a feature capable of changing the root component tag.